GNOME Bugzilla – Bug 768982
gnome-session logging to systemd journal should be configurable
Last modified: 2018-01-08 21:31:42 UTC
Created attachment 331801 [details] [review] Add a new autoconf switch to enable/disable forwarding to systemd journal Currently gnome-session sends all the logs of itself and child processes to systemd journal when systemd is enabled. However, in some distributions (e.g. SUSE) it's still desired to keep the logs in ~/.xsesssion-errors-$DISPLAY The patch adds a autoconf switch, making it possible to turn off the logs forwarding in build time. Thanks.
By the way, there is already a similar switch in gdm.
Now with the port to meson this bug can be closed, as meson options are switchable, right?
(In reply to Luciano Santos from comment #2) > Now with the port to meson this bug can be closed, as meson options are > switchable, right? Sorry, I guess not. The porting to meson didn't change the behavior, and "enable_systemd" switch is for generic systemd support IIUC. So I think we need to port the patch to meson.
(In reply to Felix Zhang from comment #3) > Sorry, I guess not. The porting to meson didn't change the behavior, and > "enable_systemd" switch is for generic systemd support IIUC. So I think we > need to port the patch to meson. I will see if I can do something about it.
Created attachment 366320 [details] [review] Patch ported to meson build system
Review of attachment 366320 [details] [review]: do it!
(In reply to Ray Strode [halfline] from comment #6) > Review of attachment 366320 [details] [review] [review]: > > do it! https://git.gnome.org/browse/gnome-session/commit/?id=099c19099de8e351f6cc0f2110ad27648780a0fe
meson.build sets HAVE_SYSTEMD_JOURNAL, but code use ENABLE_SYSTEMD_JOURNAL. That does not look right...
doh! Thanks... will fixup asap (name migrations from autofoo to meson messup)
Created attachment 366519 [details] [review] meson: rename HAVE_SYSTEMD_JOURNAL to ENABLE_SYSTEMD_JOURNAL That's what the code uses.
Attachment 366519 [details] pushed as f8358ef - meson: rename HAVE_SYSTEMD_JOURNAL to ENABLE_SYSTEMD_JOURNAL