After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768982 - gnome-session logging to systemd journal should be configurable
gnome-session logging to systemd journal should be configurable
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
git master
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-20 07:01 UTC by Felix Zhang
Modified: 2018-01-08 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a new autoconf switch to enable/disable forwarding to systemd journal (4.79 KB, patch)
2016-07-20 07:01 UTC, Felix Zhang
none Details | Review
Patch ported to meson build system (5.32 KB, patch)
2018-01-04 17:17 UTC, Dominique Leuenberger
committed Details | Review
meson: rename HAVE_SYSTEMD_JOURNAL to ENABLE_SYSTEMD_JOURNAL (2.21 KB, patch)
2018-01-08 21:31 UTC, Ray Strode [halfline]
committed Details | Review

Description Felix Zhang 2016-07-20 07:01:51 UTC
Created attachment 331801 [details] [review]
Add a new autoconf switch to enable/disable forwarding to systemd journal

Currently gnome-session sends all the logs of itself and child processes to systemd journal when systemd is enabled. However, in some distributions (e.g. SUSE) it's still desired to keep the logs in ~/.xsesssion-errors-$DISPLAY

The patch adds a autoconf switch, making it possible to turn off the logs forwarding in build time.

Thanks.
Comment 1 Felix Zhang 2016-07-20 10:05:29 UTC
By the way, there is already a similar switch in gdm.
Comment 2 Luciano Santos 2017-12-23 23:30:44 UTC
Now with the port to meson this bug can be closed, as meson options are switchable, right?
Comment 3 Felix Zhang 2017-12-25 13:48:19 UTC
(In reply to Luciano Santos from comment #2)
> Now with the port to meson this bug can be closed, as meson options are
> switchable, right?

Sorry, I guess not. The porting to meson didn't change the behavior, and "enable_systemd" switch is for generic systemd support IIUC. So I think we need to port the patch to meson.
Comment 4 Luciano Santos 2017-12-25 19:50:49 UTC
(In reply to Felix Zhang from comment #3)
> Sorry, I guess not. The porting to meson didn't change the behavior, and
> "enable_systemd" switch is for generic systemd support IIUC. So I think we
> need to port the patch to meson.

I will see if I can do something about it.
Comment 5 Dominique Leuenberger 2018-01-04 17:17:55 UTC
Created attachment 366320 [details] [review]
Patch ported to meson build system
Comment 6 Ray Strode [halfline] 2018-01-04 17:55:20 UTC
Review of attachment 366320 [details] [review]:

do it!
Comment 7 Dominique Leuenberger 2018-01-04 17:59:55 UTC
(In reply to Ray Strode [halfline] from comment #6)
> Review of attachment 366320 [details] [review] [review]:
> 
> do it!

https://git.gnome.org/browse/gnome-session/commit/?id=099c19099de8e351f6cc0f2110ad27648780a0fe
Comment 8 Alberts Muktupāvels 2018-01-04 18:40:11 UTC
meson.build sets HAVE_SYSTEMD_JOURNAL, but code use ENABLE_SYSTEMD_JOURNAL. That does not look right...
Comment 9 Dominique Leuenberger 2018-01-04 18:41:56 UTC
doh! Thanks... will fixup asap (name migrations from autofoo to meson messup)
Comment 10 Ray Strode [halfline] 2018-01-08 21:31:21 UTC
Created attachment 366519 [details] [review]
meson: rename HAVE_SYSTEMD_JOURNAL to ENABLE_SYSTEMD_JOURNAL

That's what the code uses.
Comment 11 Ray Strode [halfline] 2018-01-08 21:31:39 UTC
Attachment 366519 [details] pushed as f8358ef - meson: rename HAVE_SYSTEMD_JOURNAL to ENABLE_SYSTEMD_JOURNAL