After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768848 - Add support for new journal parameters
Add support for new journal parameters
Status: RESOLVED FIXED
Product: gnome-logs
Classification: Other
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-logs maintainer(s)
gnome-logs maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-07-15 14:44 UTC by Pranav Ganorkar
Modified: 2016-07-21 19:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change the "uid" variable type in GlJournalEntry (3.93 KB, patch)
2016-07-15 14:45 UTC, Pranav Ganorkar 		committed Details | Review
Add support for additional journal parameters (11.50 KB, patch)
2016-07-15 14:46 UTC, Pranav Ganorkar 		none Details | Review
Add support for additional journal parameters (11.48 KB, patch)
2016-07-21 13:42 UTC, Pranav Ganorkar 		committed Details | Review

Description Pranav Ganorkar 2016-07-15 14:44:51 UTC 
Support for new journal parameters like _PID, _GID, _SYSTEMD_UNIT, _EXE is added. Also, the _UID parameter is changed from integer to string for enabling substring search.
Comment 1 Pranav Ganorkar 2016-07-15 14:45:51 UTC 
Created attachment 331595 [details] [review]
Change the "uid" variable type in GlJournalEntry

This variable was changed as we need to pass it as string for substring search in gl-journal-model.Also, gl-eventviewrow class was modified to reflect the change in the "uid" variable type.
Comment 2 Pranav Ganorkar 2016-07-15 14:46:53 UTC 
Created attachment 331596 [details] [review]
Add support for additional journal parameters

More parameters like PID,GID,Systemd Unit etc are added. The tokenizer was modified to detect characters encountered in these new parameters.
Comment 3 David King 2016-07-21 09:19:10 UTC 
Review of attachment 331595 [details] [review]:

Looks good.
Comment 4 David King 2016-07-21 09:24:49 UTC 
Review of attachment 331596 [details] [review]:

::: src/gl-eventviewlist.c
@@ +468,1 @@
+/* Create query object according to selected category and set it on journal model */

The query is returned, but is not set on the journal model.
Comment 5 David King 2016-07-21 09:29:12 UTC 
Review of attachment 331595 [details] [review]:

Pushed to master as commit 03609326db64b0ef5845a0c741a3c56630d07227.
Comment 6 Pranav Ganorkar 2016-07-21 13:42:48 UTC 
Created attachment 331875 [details] [review]
Add support for additional journal parameters

More parameters like PID,GID etc are added. The tokenizer was modified to detect characters encountered in these new parameters.
Comment 7 David King 2016-07-21 19:03:54 UTC 
Review of attachment 331875 [details] [review]:

Pushed to master as commit 820c6bf250e9fd79d34faf2feed130a56310e1fa.