After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768837 - egg-counter: Silence -Wsign-compare
egg-counter: Silence -Wsign-compare
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-15 09:46 UTC by Debarshi Ray
Modified: 2016-07-16 19:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
egg-counter: Silence -Wsign-compare (724 bytes, patch)
2016-07-15 09:47 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2016-07-15 09:46:13 UTC
I get this while compiling:

egg-counter.c: In function ‘_egg_counter_arena_init_remote’:
egg-counter.c:326:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (i = 0; i < n_counters; i++)
Comment 1 Debarshi Ray 2016-07-15 09:47:02 UTC
Created attachment 331560 [details] [review]
egg-counter: Silence -Wsign-compare
Comment 2 Christian Hergert 2016-07-15 19:15:02 UTC
Review of attachment 331560 [details] [review]:

Since we enforce a check with MAX_COUNTERS, looks good to me.
Comment 3 Debarshi Ray 2016-07-16 19:28:29 UTC
Thanks for taking a look. Pushed to master.