Created attachment 331500 [details] [review]
editor-frame: Process key press events in the replace entry field

When the user presses Enter, Escape, Up, or Down when the search entry
field is focused, the search is executed, exited or advanced to the next
result, respectively. This commit replicates that behavior for the
replace entry field.

Can we do this with keybindings + signal actions instead of key-press-event? Doing things directly from key-press-event should be avoided when possible because it can screw up input-methods.

I was just copying how the search entry keybindings are set up. Is that one a special case?

Yeah, I guess it's sort of tricky to get those implemented correctly here because we would have to rely on the .css to assign the binding. We should probably add a TODO though.

Review of attachment 331500 [details] [review]:

Go ahead and push this as is, and we can take a look at using keybindings in the future.

Pushed as commit 765ddeb11cea46c591fbcdaab98e39485c1b1ffc