GNOME Bugzilla – Bug 768808
Fixes for that problem sgallagh mentioned on IRC
Last modified: 2016-07-28 12:32:47 UTC
sgallagh's /proc/keys was growing until his quota filled up. This was because gnome-online-accounts was trying to sign in over and over and over again for an unavailable KDC. Each time it did this, it leaked a credential cache. gnome-online-accounts should try to refresh over and over again because we don't have kernel keyring change notification yet, but it shouldn't try to sign in over and over and over again. Also, if sign in fails it should clean up its cache.
Created attachment 331498 [details] [review] identity: don't register new identity to list if sign in unsuccessful If we add an identity to the list when sign in fails, then we're going to prune it from the list immediately resulting in an identity-removed signal right away. This will leads to an ensure credentials call (which is needed in most cases on identity removal to synchronize state with the daemon, but not in this case), which may cause it to sign in again. This can lead to a sign in attempt every 5 seconds.
Created attachment 331499 [details] [review] identity: ensure unused credential cache is cleaned up If we end up creating a temporary credential cache that we don't need, because a new identity wasn't successfully signed in, we should clean it up.
Review of attachment 331498 [details] [review]: Ok, makes sense to me.
Review of attachment 331499 [details] [review]: Yes, looks good to me. Thanks for the fixes.
Attachment 331498 [details] pushed as 607f9ae - identity: don't register new identity to list if sign in unsuccessful Attachment 331499 [details] pushed as 517fc9c - identity: ensure unused credential cache is cleaned up
Created attachment 331577 [details] [review] telepathy-account-widgets: Revert unintended rollback of the submodule
(In reply to Ray Strode [halfline] from comment #0) > sgallagh's /proc/keys was growing until his quota filled up. Some details for those might be stopping by this bug: <sgallagh> For example, we were seeing lots of: <sgallagh> 03d89439 I--Q--- 1 perm 3f010000 13041 13041 keyring krb_ccache_SAHVhlP: empty <sgallagh> With the part after krb_ccache_ being random
Created attachment 332274 [details] [review] identity: Silence -Wincompatible-pointer-types