GNOME Bugzilla – Bug 768792
Remove -ldl in src/Makefile.am
Last modified: 2016-07-14 07:56:11 UTC
It was added in commit af6b5e8, but gnome-photos doesn't seem to need it. gnome-photos still builds without error after removing it.
Unconditionally using -ldl also causes problems on FreeBSD:
/usr/bin/ld: cannot find -ldl
clang: error: linker command failed with exit code 1 (use -v to see invocation)
FreeBSD puts dl* functions in libc, so libdl is not available and not needed. -ldl have to be checked before being used.
Created attachment 331463 [details] [review]
egg-counter: Remove unused -ldl
No dl* function calls are added, so -ldl is not needed.
Review of attachment 331463 [details] [review]:
Thanks for the patch, and very sorry about that. I merged an older patch that added EggCounter when it used to have dl_* calls. While I updated egg-counter.[ch], I failed to realize that dl_* has been replaced with GModule.