After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768792 - Remove -ldl in src/Makefile.am
Remove -ldl in src/Makefile.am
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-07-14 03:53 UTC by Ting-Wei Lan
Modified: 2016-07-14 07:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
egg-counter: Remove unused -ldl (640 bytes, patch)
2016-07-14 03:54 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-07-14 03:53:16 UTC 
It was added in commit af6b5e8, but gnome-photos doesn't seem to need it. gnome-photos still builds without error after removing it.

Unconditionally using -ldl also causes problems on FreeBSD:
  CCLD     gnome-photos
/usr/bin/ld: cannot find -ldl
clang: error: linker command failed with exit code 1 (use -v to see invocation)

FreeBSD puts dl* functions in libc, so libdl is not available and not needed. -ldl have to be checked before being used.
Comment 1 Ting-Wei Lan 2016-07-14 03:54:56 UTC 
Created attachment 331463 [details] [review]
egg-counter: Remove unused -ldl

No dl* function calls are added, so -ldl is not needed.
Comment 2 Debarshi Ray 2016-07-14 07:55:44 UTC 
Review of attachment 331463 [details] [review]:

Thanks for the patch, and very sorry about that. I merged an older patch that added EggCounter when it used to have dl_* calls. While I updated egg-counter.[ch], I failed to realize that dl_* has been replaced with GModule.