After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768777 - ui: Avoid the use of "width-request" for the search frame
ui: Avoid the use of "width-request" for the search frame
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-13 14:05 UTC by Matthew Leeds
Modified: 2016-07-14 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Avoid the use of "width-request" for the search frame (9.38 KB, patch)
2016-07-13 14:06 UTC, Matthew Leeds 		accepted-commit_now Details | Review

Description Matthew Leeds 2016-07-13 14:05:55 UTC 
See the commit message for an explanation.
Comment 1 Matthew Leeds 2016-07-13 14:06:00 UTC 
Created attachment 331412 [details] [review]
ui: Avoid the use of "width-request" for the search frame

This commit changes the search_entry and replace_entry text fields to
use width-chars instead of width-request to determine their size, and
changes the other buttons in the search frame to fill the space allotted
to them rather than hard-coding pixel values. This means that the toggle
buttons change size when the "Replace" and "Replace All" buttons are
visible, so they line up as they do in the mockups.

Avoiding "width-request" properties on widgets makes Builder more
flexible for use on different screen sizes and with different languages.
Comment 2 Christian Hergert 2016-07-13 18:49:16 UTC 
Review of attachment 331412 [details] [review]:

Looks good!
Comment 3 Matthew Leeds 2016-07-14 13:26:32 UTC 
Pushed as commit b260b836f375d204db54c7c7dd812cf6632672ea