GNOME Bugzilla – Bug 768776
message: fix annotation of message parse API returning objects
Last modified: 2016-07-15 15:44:42 UTC
.
Created attachment 331410 [details] [review] message: fix annotation of parse_device_{added,removed} gst_structure_id_get() returns a new reference so the returned device is actually (transfer full). The code using this API was already correct but the code example in comments was not.
Created attachment 331411 [details] [review] message: fix annotation of parse_stream_{collection,streams_selected} gst_structure_id_get() returns a new reference so the returned object is actually (transfer full). The unit tests was already unreffing the objects.
Created attachment 331413 [details] [review] tools: fix device leaks in gst-device-monitor gst_message_parse_device_{added,removed} is actually returning a new ref on the device.
Created attachment 331414 [details] [review] playback3: fix leaks of collection returned by message parse API gst_message_parse_stream_collection() and gst_message_parse_streams_selected() actually return a reffed GstStreamCollection.
commit 31ef1051100f1c11a038a9dd1c32753eaa8efde3 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Wed Jul 13 15:43:21 2016 +0200 message: fix annotation of parse_stream_{collection,streams_selected} gst_structure_id_get() returns a new reference so the returned object is actually (transfer full). The unit tests was already unreffing the objects. https://bugzilla.gnome.org/show_bug.cgi?id=768776 commit 514beb7d60e90f23c63a02dd2cae1af619d204b0 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Wed Jul 13 15:43:21 2016 +0200 message: fix annotation of parse_device_{added,removed} gst_structure_id_get() returns a new reference so the returned device is actually (transfer full). The code using this API was already correct but the code example in comments was not. https://bugzilla.gnome.org/show_bug.cgi?id=768776 commit a3c47a0754bfaaa4ebec94d4ea9e397c923b1cba Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Wed Jul 13 15:45:33 2016 +0200 tools: fix device leaks in gst-device-monitor gst_message_parse_device_{added,removed} is actually returning a new ref on the device. https://bugzilla.gnome.org/show_bug.cgi?id=768776
commit b83bd85ed51b779e88a4f3c79eb6bcd10ae4c437 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Wed Jul 13 16:02:25 2016 +0200 playbin3: fix leaks of collection returned by message parse API gst_message_parse_stream_collection() and gst_message_parse_streams_selected() actually return a reffed GstStreamCollection. https://bugzilla.gnome.org/show_bug.cgi?id=768776