GNOME Bugzilla – Bug 768752
Add async variant of g_app_info_launch_default_for_uri
Last modified: 2016-07-26 20:06:18 UTC
An async variant of g_app_info_launch_default_for_uri is useful for sandboxed situations, where the portal may present an app chooser dialog to the user; we really can't block until that interaction is over. It is also useful to overcome the problems we have with using this API in commandline tools which exit before the D-Bus activation of the launched app is done.
Created attachment 331380 [details] [review] Add async variant of g_app_info_launch_default_for_uri This is useful in the portalized case, when the portal may present an app chooser dialog to the user.
*** Bug 768254 has been marked as a duplicate of this bug. ***
Thanks, very useful indeed. FWIF, I've reviewed the patch and it looks perfect to me, although someone more experienced in GLib should probably review it too.
Review of attachment 331380 [details] [review]: Only a few minor comments, looks mostly good to me. ::: gio/gappinfo.c @@ +699,3 @@ + G_IO_ERROR, + G_IO_ERROR_FAILED, + guint signal_id; Should probably mention the response that was received here? @@ +737,3 @@ + task, NULL); + + GAsyncResult *result, Missing space @@ +898,3 @@ + * g_app_info_launch_default_for_uri_async: + * @uri: the uri to show +g_app_info_launch_default_for_uri (const char *uri, Nitpick: this is the only argument whose line ends with a period @@ +934,3 @@ + callback, user_data, + g_app_info_launch_default_for_uri_async, + * return after this @@ +949,3 @@ + * @context: (allow-none): an optional #GAppLaunchContext. + * @result: a #GAsyncResult + * Missing closing brace @@ +958,3 @@ + */ +gboolean + GAppLaunchContext *context, I am not sure you should pass the context here again. The context is only used to gather information about how the app is going to be launched, not about the result of the operation.
Created attachment 331634 [details] [review] Add async variant of g_app_info_launch_default_for_uri This is useful in the portalized case, when the portal may present an app chooser dialog to the user.
Review of attachment 331634 [details] [review]: Looks good, with one minor comment. ::: gio/gappinfo.c @@ +695,3 @@ + g_dbus_connection_signal_unsubscribe (connection, signal_id); + +{ options should be unreffed after this.
Attachment 331634 [details] pushed as c1e8f70 - Add async variant of g_app_info_launch_default_for_uri