After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768739 - tests: fix bus leaks in -good tests
tests: fix bus leaks in -good tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-12 15:49 UTC by Guillaume Desmottes
Modified: 2016-07-18 09:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
audiofirfilter: fix bus leak in test (1.35 KB, patch)
2016-07-12 15:50 UTC, Guillaume Desmottes
committed Details | Review
audioiirfilter: fix bus leak in test (1.35 KB, patch)
2016-07-12 15:50 UTC, Guillaume Desmottes
committed Details | Review
effectv: fix bus leak in test (1.15 KB, patch)
2016-07-12 15:50 UTC, Guillaume Desmottes
committed Details | Review
qtdemux: fix element and pad leak in test (827 bytes, patch)
2016-07-12 15:50 UTC, Guillaume Desmottes
committed Details | Review
rtp-payloading: fix bus leak in test (1.19 KB, patch)
2016-07-12 15:50 UTC, Guillaume Desmottes
committed Details | Review
videobox: fix bus leak in test (1.15 KB, patch)
2016-07-12 15:50 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2016-07-12 15:49:01 UTC
GstBus wasn't properly tracked by the leaks tracer (bug #768141) so I missed a few leaks when I did my last round of testing in -good.
Comment 1 Guillaume Desmottes 2016-07-12 15:50:10 UTC
Created attachment 331357 [details] [review]
audiofirfilter: fix bus leak in test

gst_bus_add_signal_watch() takes a ref on the bus which should be
released using gst_bus_remove_signal_watch().
Comment 2 Guillaume Desmottes 2016-07-12 15:50:16 UTC
Created attachment 331358 [details] [review]
audioiirfilter: fix bus leak in test

gst_bus_add_signal_watch() takes a ref on the bus which should be
released using gst_bus_remove_signal_watch().
Comment 3 Guillaume Desmottes 2016-07-12 15:50:21 UTC
Created attachment 331359 [details] [review]
effectv: fix bus leak in test

gst_bus_add_signal_watch() takes a ref on the bus which should be
released using gst_bus_remove_signal_watch().
Comment 4 Guillaume Desmottes 2016-07-12 15:50:25 UTC
Created attachment 331360 [details] [review]
qtdemux: fix element and pad leak in test
Comment 5 Guillaume Desmottes 2016-07-12 15:50:31 UTC
Created attachment 331361 [details] [review]
rtp-payloading: fix bus leak in test

gst_bus_add_watch() takes a ref on the bus which should be
released using gst_bus_remove_watch().
Comment 6 Guillaume Desmottes 2016-07-12 15:50:36 UTC
Created attachment 331362 [details] [review]
videobox: fix bus leak in test

gst_bus_add_watch() takes a ref on the bus which should be
released using gst_bus_remove_watch().
Comment 7 Tim-Philipp Müller 2016-07-18 09:56:24 UTC
Thanks!

commit 7da2bac2e336521238121bbe04251df7413f81f7
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Tue Jul 12 17:30:56 2016 +0200

    tests: qtdemux: fix element and pad leak
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768739

commit 94232da66554cc78029cdaffb059c0fa2e192475
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Tue Jul 12 16:45:36 2016 +0200

    tests: fix bus leaks
    
    gst_bus_add_signal_watch() takes a ref on the bus which should be
    released using gst_bus_remove_signal_watch().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768739