Created attachment 331328 [details] [review]
actor: Clarify that add_effect() sinks floating references on the effect

So if you want to reuse a ClutterEffect, make sure to
g_object_ref_sink() it yourself first.

Review of attachment 331328 [details] [review]:

It kind of goes with the territory of inheriting from GInitiallyUnowned, and we don't really mention it in other places — for instance, in the whole API dealing with children actors.

Anyway, it looks good.

True, although it was definitely not clear to me that ClutterEffect was a GInitiallyUnowned until I noticed in its inheritance tree and suddenly everything clicked about why I’d just spent a few hours tracing down some magically finalising ClutterEffects. :-)

Attachment 331328 [details] pushed as d7372cc - actor: Clarify that add_effect() sinks floating references on the effect