After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768725 - gstrtpsession: Add parameter to control EOS events on RTCP pad
gstrtpsession: Add parameter to control EOS events on RTCP pad
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-12 12:06 UTC by Jose Antonio Santos Cadenas
Modified: 2018-05-06 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstrtpsession: Add parameter to control EOS events on RTCP pad (3.87 KB, patch)
2016-07-12 12:06 UTC, Jose Antonio Santos Cadenas 		rejected Details | Review

Description Jose Antonio Santos Cadenas 2016-07-12 12:06:11 UTC 
Created attachment 331319 [details] [review]
gstrtpsession: Add parameter to control EOS events on RTCP pad

Currently, when a session is ended an a bye package is sent,
a EOS event is sent. If a bundle transport is used, this
causes other RTCP events, from other sources, not to reach its
destination because downstream element rejects more buffers. This
can be worse if no encryption is used. Once the EOS is sent,
all buffers are rejected RTCP and RTP.
Comment 1 Sebastian Dröge (slomo) 2016-07-12 12:12:58 UTC 
Maybe we need a way to know from the caps if we have a bundle transport, and what the contained SSRCs are so that we send EOS once all of them are BYE.

See also https://cgit.freedesktop.org/~wtay/gstreamer/log/?h=mixed-caps, which was an idea how to implement that.
Comment 2 Jose Antonio Santos Cadenas 2016-07-12 12:18:06 UTC 
Unfortunately I haven't seen a way to differentiate that in the caps. More over, if you use one GstRtpSession element for managing multiple session (something that is working correctly) you have to also avoid EOS event when a session is ended.
Comment 3 Olivier Crête 2016-07-12 22:09:26 UTC 
This isn't specific to RTCP, whatever is "bundling" the sessions should wait for all bundled sessions to have received a EOS before forwarding it. How are you bundling them? But this patch is definitely not the right way to do this.
Comment 4 Sebastian Dröge (slomo) 2016-10-20 09:47:38 UTC 
Also see https://bugzilla.gnome.org/show_bug.cgi?id=772740 for bundle support, and https://bugzilla.gnome.org/show_bug.cgi?id=773218 for (probably) the underlying EOS issue here.

Can we consider this bug here obsolete?