After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768661 - cerbero: add recipe for libunwind
cerbero: add recipe for libunwind
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal enhancement
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-11 09:59 UTC by Guillaume Desmottes
Modified: 2016-07-25 07:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libunwind: add recipe (1.01 KB, patch)
2016-07-11 09:59 UTC, Guillaume Desmottes
committed Details | Review
gstreamer-1.0: add 'unwind' variant (1.32 KB, patch)
2016-07-11 10:24 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2016-07-11 09:59:20 UTC
.
Comment 1 Guillaume Desmottes 2016-07-11 09:59:41 UTC
Created attachment 331199 [details] [review]
libunwind: add recipe
Comment 2 Guillaume Desmottes 2016-07-11 10:00:41 UTC
Do we want to add this as a dep when building gst core on Linux? Or should we let people we care about it build it manually in their cerbero tree and then rebuild core?
Comment 3 Sebastian Dröge (slomo) 2016-07-11 10:03:08 UTC
This only makes sense on Linux (or ELF based systems), right? So maybe add it for Linux, make it a variant and have that enabled by default for normal Linux and optional for Android (or anything else).
Comment 4 Sebastian Dröge (slomo) 2016-07-11 10:04:11 UTC
Review of attachment 331199 [details] [review]:

::: recipes/libunwind.recipe
@@ +4,3 @@
+    name = 'libunwind'
+    version = '1.1'
+    licenses = [License.MIT]

According to Debian, it's having the expat license. Not MIT
Comment 5 Guillaume Desmottes 2016-07-11 10:06:06 UTC
(In reply to Sebastian Dröge (slomo) from comment #4)
> Review of attachment 331199 [details] [review] [review]:
> 
> ::: recipes/libunwind.recipe
> @@ +4,3 @@
> +    name = 'libunwind'
> +    version = '1.1'
> +    licenses = [License.MIT]
> 
> According to Debian, it's having the expat license. Not MIT

http://www.nongnu.org/libunwind/download.html claims it's MIT.
but http://git.savannah.gnu.org/gitweb/?p=libunwind.git;a=blob;f=LICENSE;h=c9b44cb8aaebb163e8524d67558696aa965ad0ec;hb=HEAD is not that clear.
Comment 6 Guillaume Desmottes 2016-07-11 10:24:48 UTC
Created attachment 331202 [details] [review]
gstreamer-1.0: add 'unwind' variant
Comment 7 Sebastian Dröge (slomo) 2016-07-25 06:47:26 UTC
Attachment 331199 [details] pushed as 297d649 - libunwind: add recipe
Attachment 331202 [details] pushed as b543485 - gstreamer-1.0: add 'unwind' variant
Comment 8 Sebastian Dröge (slomo) 2016-07-25 06:49:29 UTC
commit 28ed2009cf32cbd928013c8476bfe38465b93f34
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jul 25 09:48:55 2016 +0300

    gstreamer-1.0: Add libunwind to the files list if variant is selected