After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768657 - places-view: fix open action for locations without a mount or volume
places-view: fix open action for locations without a mount or volume
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-07-11 09:50 UTC by Razvan Chitu
Modified: 2016-07-12 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
places-view: fix open action for locations without a mount or volume (1.48 KB, patch)
2016-07-11 09:50 UTC, Razvan Chitu
reviewed Details | Review
placesview: fix open action for locations without a mount or volume (1.44 KB, patch)
2016-07-12 09:12 UTC, Razvan Chitu
committed Details | Review
places-view: fetch updates from gtk+ repo (29.19 KB, patch)
2016-07-12 10:17 UTC, Razvan Chitu
committed Details | Review

Description Razvan Chitu 2016-07-11 09:50:20 UTC
See patches.
Comment 1 Razvan Chitu 2016-07-11 09:50:24 UTC
Created attachment 331196 [details] [review]
places-view: fix open action for locations without a mount or volume

In the "Other Locations" view, locations can be opened from the context menu
based on their mount or volume. However, some locations, like "Computer", do not
have either of those so they cannot be opened from the context menu. In order to
fix this, the file associated with the location can be used as well.
Comment 2 Carlos Soriano 2016-07-12 08:36:56 UTC
Review of attachment 331196 [details] [review]:

Looks good to me, thanks Razvan!

However, this needs to go into gtk+ directly. Nautilus pulls a copy of the code using /gtk/gtk-code-generator.sh

So if you want move the patch to gtk+ repo gtkplacesview.c and then once is commited, run the code generator in nautilus and create a new commit with the new code.
Comment 3 Razvan Chitu 2016-07-12 09:12:18 UTC
Created attachment 331309 [details] [review]
placesview: fix open action for locations without a mount or volume

In the "Other Locations" view, locations can be opened from the context menu
based on their mount or volume. However, some locations, like "Computer", do not
have either of those so they cannot be opened from the context menu. In order to
fix this, the file associated with the location can be used as well.
Comment 4 Carlos Soriano 2016-07-12 09:46:51 UTC
Review of attachment 331309 [details] [review]:

LGTM, I think we can just commit this one already.
Comment 5 Razvan Chitu 2016-07-12 09:58:24 UTC
Comment on attachment 331309 [details] [review]
placesview: fix open action for locations without a mount or volume

Attachment 331309 [details] pushed as 9747312 - placesview: fix open action for locations without a mount or volume
Comment 6 Razvan Chitu 2016-07-12 10:17:02 UTC
Created attachment 331312 [details] [review]
places-view: fetch updates from gtk+ repo
Comment 7 Carlos Soriano 2016-07-12 11:10:35 UTC
Review of attachment 331312 [details] [review]:

LGTM thanks!
Comment 8 Razvan Chitu 2016-07-12 11:18:05 UTC
Attachment 331312 [details] pushed as 25f4baf - places-view: fetch updates from gtk+ repo