GNOME Bugzilla – Bug 768616
gstreamer-1.0.mk: Replacement fails
Last modified: 2016-07-25 07:13:59 UTC
gstreamer.mk tries to do the following replacements: ifeq ($(GSTREAMER_INCLUDE_FONTS),yes) GSTREAMER_INCLUDE_FONTS_SUBST="" else GSTREAMER_INCLUDE_FONTS_SUBST="//" endif ifeq ($(GSTREAMER_INCLUDE_CA_CERTIFICATES),yes) GSTREAMER_INCLUDE_CA_CERTIFICATES_SUBST="" else GSTREAMER_INCLUDE_CA_CERTIFICATES_SUBST="//" endif ifneq (,$(findstring yes,$(GSTREAMER_INCLUDE_FONTS)$(GSTREAMER_INCLUDE_CA_CERTIFICATES))) GSTREAMER_COPY_FILE_SUBST="" else GSTREAMER_COPY_FILE_SUBST="//" endif [...] @"$(SED)" "s;@INCLUDE_FONTS@;$(GSTREAMER_INCLUDE_FONTS_SUBST);g" $(GSTREAMER_NDK_BUILD_PATH)/GStreamer.java | \ "$(SED)" "s;@INCLUDE_CA_CERTIFICATES@;$(GSTREAMER_INCLUDE_CA_CERTIFICATES_SUBST);g" | \ "$(SED)" "s;@INCLUDE_COPY_FILE@;$(GSTREAMER_COPY_FILE_SUBST);g" \ > $(GSTREAMER_JAVA_SRC_DIR)/org/freedesktop/gstreamer/GStreamer.java This fails because the replacement is set to one double quote character, and the double quote character ends the replacement statement prematurely. This seems to work after modifying the statements which set the replacement values: ifeq ($(GSTREAMER_INCLUDE_FONTS),yes) GSTREAMER_INCLUDE_FONTS_SUBST := else GSTREAMER_INCLUDE_FONTS_SUBST := // endif ifeq ($(GSTREAMER_INCLUDE_CA_CERTIFICATES),yes) GSTREAMER_INCLUDE_CA_CERTIFICATES_SUBST := else GSTREAMER_INCLUDE_CA_CERTIFICATES_SUBST := // endif ifneq (,$(findstring yes,$(GSTREAMER_INCLUDE_FONTS)$(GSTREAMER_INCLUDE_CA_CERTIFICATES))) GSTREAMER_COPY_FILE_SUBST := else GSTREAMER_COPY_FILE_SUBST := // endif gstreamer.mk is called by Android.mk which is part of gstreamer android tutorial-5. To build, I call ndk-build.cmd, which is part of Android NDK. I downloaded gstreamer from here: https://gstreamer.freedesktop.org/data/pkg/android/1.9.1/gstreamer-1.0-android-armv7-1.9.1.tar.bz2
Can you provide a patch/diff of your changes? I understand you correctly that your change is to remove the " " around the values in the assignment of those variables?
Created attachment 331625 [details] [review] Patch for gstreamer-1.0.mk in gstreamer-1.0-android-armv7-1.9.1 > > I understand you correctly that your change is to remove the " " around the values in the assignment of those variables? > That's correct. Otherwise, the quotes become part of the variables' value. I've attached a patch file.
Let's handle that in the original bug then, you attached a patch with both changes there anyway :) *** This bug has been marked as a duplicate of bug 768326 ***