After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768600 - Document gsettings keys
Document gsettings keys
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Preferences
3.20.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-09 00:13 UTC by Christian Stadelmann
Modified: 2018-04-26 17:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a description (893 bytes, patch)
2017-04-24 13:38 UTC, Christian Stadelmann
accepted-commit_now Details | Review
Same patch but with a fixed "From:" field (935 bytes, patch)
2017-05-15 18:26 UTC, Christian Stadelmann
committed Details | Review

Description Christian Stadelmann 2016-07-09 00:13:54 UTC
Steps to reproduce:
1. set org.gnome.epiphany.lockdown.disable-history to true
2. start epiphany, browse
3. close epiphany
4. start epiphany
5. look at history or new tab page

What happens:
History persists

What should happen:
History should be gone

Affected version:
epiphany-3.20.3-1.fc24.x86_64
Comment 1 Michael Catanzaro 2016-07-09 17:41:51 UTC
The setting has a confusing name, but it's actually used to remove the back/forward navigation buttons (useful for web kiosks).

We've had several requests to add a way to disable history, perhaps with a setting to always open the browser in incognito mode. I'd be interested if anybody wants to work on something along those lines, but let's do it in a different bug.
Comment 2 Christian Stadelmann 2016-07-11 14:43:17 UTC
How about adding a documentation to those dconf keys then, so that users of e.g. dconf-editor can read them?
Comment 3 Michael Catanzaro 2016-07-11 16:05:19 UTC
Yeah, we should add descriptions for the gsettings keys, indeed.
Comment 4 Christian Stadelmann 2017-04-24 13:38:52 UTC
Created attachment 350297 [details] [review]
Add a description
Comment 5 Michael Catanzaro 2017-04-24 13:59:29 UTC
Review of attachment 350297 [details] [review]:

Sure
Comment 6 Michael Catanzaro 2017-05-15 18:09:09 UTC
Was about to push this but I notice the commit authorship is set to %ªûGV <%ªûGV>. Do you want to fix that?
Comment 7 Christian Stadelmann 2017-05-15 18:26:07 UTC
Created attachment 351916 [details] [review]
Same patch but with a fixed "From:" field

(In reply to Michael Catanzaro from comment #6)
> Was about to push this but I notice the commit authorship is set to %ªûGV
> <%ªûGV>. Do you want to fix that?

Oops, that was a fallout from bug #777932.
Comment 8 Michael Catanzaro 2017-12-11 14:43:52 UTC
Does this need to be rebased now?