GNOME Bugzilla – Bug 768598
intltool used by damned-lies needs a patch to support JS and Vala
Last modified: 2018-09-17 06:50:41 UTC
Created attachment 331114 [details] [review] Add JavaScript, Lua and Vala to $buildin_gettext_support intltool is unmaintained upstream and it currently has a couple of bugs that are problematic to us in GNOME. One of them is that various formats are not detected by intltool-update: https://bugs.launchpad.net/intltool/+bug/544445 https://bugs.launchpad.net/intltool/+bug/1039983 I have submitted a simple patch that fixes the issue, but it is unlikely to get merged and released: https://bugs.launchpad.net/intltool/+bug/1325597 I'm asking to patch the copy of intltool that is used by damned-lies.
Patch has landed. Please confirm.
I tested it on rygel: https://git.gnome.org/browse/rygel/commit/?id=c3f6e7b7e853c77d185ca6e78d43ead370f68a03 and it works as intended. Thank you!
Damned Lies no longer detects missing .js and .vala files. Has the patch been removed?
Rebuilt the package against the latest updated package that shipped with Xenial. It'd be lovely to have this pushed upstream, can you please submit the patch to Debian as well so that it might be merged in at some point? Please confirm/close this bug accordingly.
(In reply to Andrea Veri from comment #4) > Rebuilt the package against the latest updated package that shipped with > Xenial. It'd be lovely to have this pushed upstream, can you please submit > the patch to Debian as well so that it might be merged in at some point? > I have submitted it to Debian last year: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855878 Upstream is as dead as they come, unfortunately. > Please confirm/close this bug accordingly. Thank you! I’ll close it for now (can’t really test without messy test commits), and re-open if necessary.
(In reply to Piotr Drąg from comment #5) > (In reply to Andrea Veri from comment #4) > > Please confirm/close this bug accordingly. > > Thank you! I’ll close it for now (can’t really test without messy test > commits), and re-open if necessary. Just confirming that it detected a missing .vala file today, so all is right.
This regressed again (and there have been no progress in Debian.)
Piotr, should be fixed (again), can you please send the patch to Ubuntu instead (seems there have been new intltool revisions recently [1])? Thanks! [1] https://launchpad.net/ubuntu/bionic/+source/intltool/+changelog