GNOME Bugzilla – Bug 768595
lv2: Does not build with lilv 0.20
Last modified: 2016-07-14 17:41:31 UTC
The lv2 plugin does not build against lilv 0.20 after: commit adf2092b3da83d837001711614570f6b9996f538 Author: Stefan Sauer <ensonic@users.sf.net> Date: Sat Jul 2 10:24:51 2016 +0200 lv2: add support for saving presets
I'll downgrade mine, but the next time, please post the errors you get.
I've been building against 0.22.1
It is just that you use newly introduced API. You and Thibault just need to agree in bumping the requirement or dropping this patch.
commit 13d963fbf0223910cff55dae1f2bd0b653b19394 Author: Stefan Sauer <ensonic@users.sf.net> Date: Sun Jul 10 20:42:42 2016 +0200 lv2: keep working with older versions Provide a fallback impl. for the only new function we were using from 0.22. Fixes #768595
Not yet apparently: CC libgstlv2_la-gstlv2utils.lo gstlv2utils.c: In function 'gst_lv2_delete_preset': gstlv2utils.c:364:38: error: implicit declaration of function 'lilv_state_get_uri' [-Werror=implicit-function-declaration] lilv_world_unload_resource (world, lilv_state_get_uri (state)); ^~~~~~~~~~~~~~~~~~ gstlv2utils.c:364:3: error: nested extern declaration of 'lilv_state_get_uri' [-Werror=nested-externs] lilv_world_unload_resource (world, lilv_state_get_uri (state)); ^~~~~~~~~~~~~~~~~~~~~~~~~~ gstlv2utils.c:364:38: error: passing argument 2 of 'lilv_world_unload_resource' makes pointer from integer without a cast [-Werror=int-conversion] lilv_world_unload_resource (world, lilv_state_get_uri (state)); ^~~~~~~~~~~~~~~~~~ In file included from gstlv2.h:26:0, from gstlv2utils.c:28: /usr/include/lilv-0/lilv/lilv.h:580:1: note: expected 'const LilvNode * {aka const struct LilvNodeImpl *}' but argument is of type 'int' lilv_world_unload_resource(LilvWorld* world, ^~~~~~~~~~~~~~~~~~~~~~~~~~ gstlv2utils.c:365:3: error: implicit declaration of function 'lilv_state_delete' [-Werror=implicit-function-declaration] lilv_state_delete (world, state); ^~~~~~~~~~~~~~~~~ gstlv2utils.c:365:3: error: nested extern declaration of 'lilv_state_delete' [-Werror=nested-externs] cc1: all warnings being treated as errors Makefile:919: recipe for target 'libgstlv2_la-gstlv2utils.lo' failed make: *** [libgstlv2_la-gstlv2utils.lo] Error 1
commit ea443a3fcc4e5cdd76b986b594f0d653eb72f6a5 Author: Stefan Sauer <ensonic@users.sf.net> Date: Thu Jul 14 19:38:26 2016 +0200 lv2: make it build with older lilv Implementing the removal of presets is unfortunately not feasibla with versions < 0.22. Fixes #768595