GNOME Bugzilla – Bug 768571
doc: gtkdoc doesn't generate xml data
Last modified: 2016-07-11 19:31:09 UTC
Created attachment 331080 [details] [review] [PATCH] use brace expansion, not command substitution See patch log message
Comment on attachment 331080 [details] [review] [PATCH] use brace expansion, not command substitution Makes sense to me, can you ask Stefan for a second opinion though? gtk-doc.mak is from gtk-doc.
Makes sense. Moving to gtk-doc. Could you please reattach the patch? If you prefer I can patch it up and push it.
Regression from 59fe16c2
@Stefan, @Sebastian. In gtk-doc the code is correct. There's no regressions. The problem is gst-common specific, a regression from f363b320 ... Giving a second thought, @Stefan, do you mean to change all the parentheses to braces at string handling?
To be f363b320 in common, made the gtk-doc-plugins.mak the same as upstream, but in gtk-doc.mak it uses $$(_source_dir) and not $${_source_dir}. Hence your patch is correct, sorry for the mess up. Move it back to gstreamer and applying.
The following fix has been pushed: f49c55e use brace expansion, not command substitution
Created attachment 331260 [details] [review] use brace expansion, not command substitution Recently noticed that gtk-doc stopped to extract the internal documentation (appeared just API, but no description). The problem seems to be a regression from commit f363b32, where the expasion of the variable _source_dir is expanded using parentheses, which are used for command substitution, when the variable need to be a string expansion, and for that brace are needed by the shell.