After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768571 - doc: gtkdoc doesn't generate xml data
doc: gtkdoc doesn't generate xml data
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
unspecified
Other Linux
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-08 13:39 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-07-11 19:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] use brace expansion, not command substitution (1.44 KB, patch)
2016-07-08 13:39 UTC, Víctor Manuel Jáquez Leal
committed Details | Review
use brace expansion, not command substitution (1.50 KB, patch)
2016-07-11 19:12 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-07-08 13:39:32 UTC
Created attachment 331080 [details] [review]
[PATCH] use brace expansion, not command substitution

See patch log message
Comment 1 Sebastian Dröge (slomo) 2016-07-11 06:35:51 UTC
Comment on attachment 331080 [details] [review]
[PATCH] use brace expansion, not command substitution

Makes sense to me, can you ask Stefan for a second opinion though? gtk-doc.mak is from gtk-doc.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2016-07-11 12:46:57 UTC
Makes sense. Moving to gtk-doc. Could you please reattach the patch? If you prefer I can patch it up and push it.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2016-07-11 12:48:39 UTC
Regression from 59fe16c2
Comment 4 Víctor Manuel Jáquez Leal 2016-07-11 14:45:55 UTC
@Stefan, @Sebastian.


In gtk-doc the code is correct. There's no regressions. 

The problem is gst-common specific, a regression from f363b320

...

Giving a second thought, @Stefan, do you mean to change all the parentheses to braces at string handling?
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2016-07-11 19:09:25 UTC
To be f363b320 in common, made the gtk-doc-plugins.mak the same as upstream, but in gtk-doc.mak it uses $$(_source_dir) and not $${_source_dir}.

Hence your patch is correct, sorry for the mess up. Move it back to gstreamer and applying.
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2016-07-11 19:12:22 UTC
The following fix has been pushed:
f49c55e use brace expansion, not command substitution
Comment 7 Stefan Sauer (gstreamer, gtkdoc dev) 2016-07-11 19:12:31 UTC
Created attachment 331260 [details] [review]
use brace expansion, not command substitution

Recently noticed that gtk-doc stopped to extract the internal
documentation (appeared just API, but no description).

The problem seems to be a regression from commit f363b32, where the
expasion of the variable _source_dir is expanded using parentheses,
which are used for command substitution, when the variable need to
be a string expansion, and for that brace are needed by the shell.