After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768565 - shout2: fix GstPoll being used as timer and non timer
shout2: fix GstPoll being used as timer and non timer
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-08 12:00 UTC by Vincent Penquerc'h
Modified: 2016-07-08 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shout2: fix GstPoll being used as timer and non timer (823 bytes, patch)
2016-07-08 12:00 UTC, Vincent Penquerc'h 		reviewed Details | Review

Description Vincent Penquerc'h 2016-07-08 12:00:05 UTC 
shout2: fix GstPoll being used as timer and non timer
Comment 1 Vincent Penquerc'h 2016-07-08 12:00:37 UTC 
Created attachment 331072 [details] [review]
shout2: fix GstPoll being used as timer and non timer

shout2: fix GstPoll being used as timer and non timer
Comment 2 Vincent Penquerc'h 2016-07-08 12:01:07 UTC 
This fixes the generic/states test.
Comment 3 Sebastian Dröge (slomo) 2016-07-08 12:09:47 UTC 
Comment on attachment 331072 [details] [review]
shout2: fix GstPoll being used as timer and non timer

Isn't that the same as

commit 9abc31df1a498a13e255a899756efc9ca4b299a4
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Jun 29 23:31:20 2016 +0200

    shout2: Use a non-timer GstPoll
    
    Otherwise set_flushing() will have undefined semantics and nowadays causes a
    g_critical() to warn about that.
Comment 4 Vincent Penquerc'h 2016-07-08 12:11:51 UTC 
Sigh. Byte for byte :)