After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768560 - gio/tests/gsettings: fix GSettings reference leaks in some tests
gio/tests/gsettings: fix GSettings reference leaks in some tests
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gsettings
2.49.x
Other Linux
: Normal minor
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-07-08 09:26 UTC by Aurélien Zanelli
Modified: 2016-07-17 00:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio/tests/gsettings: unref settings when test_l10n(_context) tests are skipped (1.41 KB, patch)
2016-07-08 09:26 UTC, Aurélien Zanelli 		none Details | Review
gio/tests/gsettings: fix GSettings reference leaks in some tests (2.19 KB, patch)
2016-07-08 12:45 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2016-07-08 09:26:16 UTC 
Currently in gsettings tests suite, a settings object reference is leaked in test_l10n and test_l10n_context function when translation is not working.
Comment 1 Aurélien Zanelli 2016-07-08 09:26:59 UTC 
Created attachment 331064 [details] [review]
gio/tests/gsettings: unref settings when test_l10n(_context) tests are skipped
Comment 2 Aurélien Zanelli 2016-07-08 12:45:40 UTC 
Created attachment 331075 [details] [review]
gio/tests/gsettings: fix GSettings reference leaks in some tests

I found more leaks in GSettings so I adress them in the same patch.
Comment 3 Matthias Clasen 2016-07-13 02:26:35 UTC 
Review of attachment 331075 [details] [review]:

ok
Comment 4 Matthias Clasen 2016-07-17 00:57:35 UTC 
Attachment 331075 [details] pushed as b121a79 - gio/tests/gsettings: fix GSettings reference leaks in some tests