After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768557 - Replace deprecated GNOME_COMPILE_WARNINGS with AX_COMPILER_FLAGS
Replace deprecated GNOME_COMPILE_WARNINGS with AX_COMPILER_FLAGS
Status: RESOLVED OBSOLETE
Product: grilo
Classification: Other
Component: general
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-07-08 08:54 UTC by Alberto Garcia
Modified: 2018-09-24 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for Grilo (803 bytes, patch)
2016-09-19 22:46 UTC, Alberto Garcia
none Details | Review
Patch for Grilo-plugins (835 bytes, patch)
2016-09-19 23:09 UTC, Alberto Garcia
none Details | Review
tests: fix warnings on thetvdb resolve shows (2.77 KB, patch)
2016-10-21 22:35 UTC, Victor Toso
none Details | Review
tests: fix warnings on thetvdb resolve stress (2.14 KB, patch)
2016-10-21 22:35 UTC, Victor Toso
none Details | Review
tests: fix warnings on thetvdb resolve episodes (2.22 KB, patch)
2016-10-21 22:36 UTC, Victor Toso
none Details | Review
tests: fix warnings on vimeo (1.08 KB, patch)
2016-10-21 22:36 UTC, Victor Toso
none Details | Review
tests: fix warnings on tmdb preconditions (1.51 KB, patch)
2016-10-21 22:36 UTC, Victor Toso
none Details | Review
tests: fix warnings on tmdb full resolution (2.23 KB, patch)
2016-10-21 22:36 UTC, Victor Toso
none Details | Review
tests: fix warnings on tmdb fast resolution (1.60 KB, patch)
2016-10-21 22:36 UTC, Victor Toso
none Details | Review
tests: fix warnings on tmdb fast resolution by id (1.68 KB, patch)
2016-10-21 22:37 UTC, Victor Toso
none Details | Review
tests: fix warnings on tmdb missing configuration (1.67 KB, patch)
2016-10-21 22:37 UTC, Victor Toso
none Details | Review
tests: fix warning on games (1.59 KB, patch)
2016-10-21 22:37 UTC, Victor Toso
none Details | Review
examples: fix warnings on example-tmdb (3.66 KB, patch)
2016-10-21 22:37 UTC, Victor Toso
none Details | Review

Description Alberto Garcia 2016-07-08 08:54:50 UTC
The macros in gnome-common (GNOME_COMPILE_WARNINGS in this case) are
deprecated. See here for details:

https://wiki.gnome.org/Projects/GnomeCommon/Migration

This applies to both grilo and grilo-plugins
Comment 1 Alberto Garcia 2016-09-19 22:46:18 UTC
Created attachment 335880 [details] [review]
Patch for Grilo
Comment 2 Alberto Garcia 2016-09-19 23:09:15 UTC
Created attachment 335881 [details] [review]
Patch for Grilo-plugins
Comment 3 Victor Toso 2016-10-21 21:32:47 UTC
Hi Alberto, thanks for the patches.

1) They don't have commit message
2) Soooo many warnings that they will introduce!

I would like to include your patch with at least some fixes for this warnings. I'll try to fix some now.

Cheers,
Comment 4 Victor Toso 2016-10-21 22:35:51 UTC
Created attachment 338218 [details] [review]
tests: fix warnings on thetvdb resolve shows

-Wdiscarded-qualifiers and -Wdeclaration-after-statement such as:

-Wdiscarded-qualifiers
 warning: initialization discards ‘const’ qualifier from pointer target type
 { "CSI: Miami", "CSI - Miami", "78310", "tt0313043" },
   ^~~~~~~~~~~~

-Wdeclaration-after-statement such as:
 warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   gint result = g_test_run ();
   ^~~~
Comment 5 Victor Toso 2016-10-21 22:35:59 UTC
Created attachment 338219 [details] [review]
tests: fix warnings on thetvdb resolve stress

-Wdiscarded-qualifiers and -Wdeclaration-after-statement such as:

-Wdiscarded-qualifiers
 warning: initialization discards ‘const’ qualifier from pointer target type
 {"House", "Everybody Dies", 8, 22,
  ^~~~~~~

-Wdeclaration-after-statement
 warning: ISO C90 forbids mixed declarations and code
 gint result = g_test_run ();
 ^~~~
Comment 6 Victor Toso 2016-10-21 22:36:08 UTC
Created attachment 338220 [details] [review]
tests: fix warnings on thetvdb resolve episodes

-Wdiscarded-qualifiers and -Wdeclaration-after-statement such as:

-Wdiscarded-qualifiers
 warning: initialization discards ‘const’ qualifier from pointer target type
 "tt0409591", "446714", "SH774951", "2006-10-05",
                                    ^~~~~~~~~~~~

-Wdeclaration-after-statement
 warning: ISO C90 forbids mixed declarations and code
 gint result = g_test_run ();
 ^~~~
Comment 7 Victor Toso 2016-10-21 22:36:16 UTC
Created attachment 338221 [details] [review]
tests: fix warnings on vimeo

warning: ISO C90 forbids mixed declarations and code
 gint result = g_test_run ();
 ^~~~
Comment 8 Victor Toso 2016-10-21 22:36:24 UTC
Created attachment 338222 [details] [review]
tests: fix warnings on tmdb preconditions

warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 GrlSource *source = test_get_source();
 ^~~~~~~~~
Comment 9 Victor Toso 2016-10-21 22:36:38 UTC
Created attachment 338223 [details] [review]
tests: fix warnings on tmdb full resolution

warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 guint count = grl_data_length (GRL_DATA (media), GRL_METADATA_KEY_REGION);
 ^~~~~
Comment 10 Victor Toso 2016-10-21 22:36:55 UTC
Created attachment 338224 [details] [review]
tests: fix warnings on tmdb fast resolution

warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 GrlSource *source = test_get_source();
 ^~~~~~~~~
Comment 11 Victor Toso 2016-10-21 22:37:11 UTC
Created attachment 338225 [details] [review]
tests: fix warnings on tmdb fast resolution by id

warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 GrlSource *source = test_get_source();
 ^~~~~~~~~
Comment 12 Victor Toso 2016-10-21 22:37:25 UTC
Created attachment 338226 [details] [review]
tests: fix warnings on tmdb missing configuration

warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 GrlSource *source = test_get_source();
 ^~~~~~~~~
Comment 13 Victor Toso 2016-10-21 22:37:35 UTC
Created attachment 338227 [details] [review]
tests: fix warning on games

warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 gint result = g_test_run ();
 ^~~~
Comment 14 Victor Toso 2016-10-21 22:37:45 UTC
Created attachment 338228 [details] [review]
examples: fix warnings on example-tmdb

All -Wdeclaration-after-statement such as:

 warning: ISO C90 forbids mixed declarations and code
 const gchar *title = grl_media_get_title (media);
 ^~~~~
Comment 15 Victor Toso 2016-10-21 22:39:19 UTC
(1) not yet close to finish warnings in grilo-plugins
(2) I don't really mind to squash some of theses patches, i prefer to have them split and squash then having to split later on =)
(3) patches welcome!
Comment 16 gnome.vrb 2016-11-26 21:42:29 UTC
I think it is better to have separate bugs for grilo / grilo-plugins, as this bug has and will have more patches. This will make patch testing easier with the below git-bz command:

[user@git/grilo-plugins]$ git-bz apply 768557
[user@git/grilo]$ git-bz apply <new-bugid>

Ref: http://git.fishsoup.net/man/git-bz.html
Comment 17 GNOME Infrastructure Team 2018-09-24 09:45:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/93.