After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768549 - Test failure: test_ip_sync_dgram
Test failure: test_ip_sync_dgram
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.48.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-07-08 07:37 UTC by Daniel Macks
Modified: 2016-07-12 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove an erroneous check in the non-sendmmsg() version of g_socket_send_messages() (1.03 KB, patch)
2016-07-11 21:51 UTC, Dan Winship
committed Details | Review

Description Daniel Macks 2016-07-08 07:37:21 UTC
Building glib-2.48.1 on OS X 10.11 with xcode-7.3.1, I get a self-test failure in gio/tests:

ERROR: inet-address - too few tests run (expected 11, got 6)
ERROR: inet-address - exited with status 134 (terminated by signal 6?)

From gio/tests/socket.log:

PASS: socket 12 /socket/unix-connection-ancillary-data
**
GLib-GIO:ERROR:socket.c:709:test_ip_sync_dgram: assertion failed (error == NULL): Error sending message: Destination address required (g-io-error-quark, 0)
# Start of ipv4_sync tests
../../tap-test: line 5: 35935 Abort trap: 6           $1 -k --tap
# GLib-GIO:ERROR:socket.c:709:test_ip_sync_dgram: assertion failed (error == NULL): Error sending message: Destination address required (g-io-error-quark, 0)
ERROR: socket - too few tests run (expected 20, got 12)
ERROR: socket - exited with status 134 (terminated by signal 6?)

This test is documented to see how g_socket_send_messages() behaves when "omitting the destination address".
Comment 1 Dan Winship 2016-07-11 21:51:06 UTC
Created attachment 331278 [details] [review]
Remove an erroneous check in the non-sendmmsg() version of g_socket_send_messages()

--------

Philip, this is correct, right?
Comment 2 Philip Withnall 2016-07-12 12:24:05 UTC
(In reply to Dan Winship from comment #1)
> Created attachment 331278 [details] [review] [review]
> Remove an erroneous check in the non-sendmmsg() version of
> g_socket_send_messages()
> 
> --------
> 
> Philip, this is correct, right?

Yes, looks correct, though the commit message could do with being a bit more explanatory.
Comment 3 Dan Winship 2016-07-12 13:14:46 UTC
Attachment 331278 [details] pushed as e0bb25c - Remove an erroneous check in the non-sendmmsg() version of g_socket_send_messages()