After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768538 - Hide ignored events in calendar as well
Hide ignored events in calendar as well
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-07-07 23:32 UTC by Florian Müllner
Modified: 2016-07-08 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
calendar: Move handling of ignored events to event source (3.96 KB, patch)
2016-07-07 23:32 UTC, Florian Müllner 		committed Details | Review
calendar: Refresh calendar when ignored events changes (1.13 KB, patch)
2016-07-07 23:32 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-07-07 23:32:26 UTC 
When all a day's events have been dismissed, the events section in the message list won't show any events, however the day is still marked in the calendar as having events.
Comment 1 Florian Müllner 2016-07-07 23:32:30 UTC 
Created attachment 331039 [details] [review]
calendar: Move handling of ignored events to event source

Ignoring events is currently implemented in the message list's
event section, which means that the calendar does not consider
ignored events when marking days with events. In order to fix
this, move the handling of ignored events to the event source,
which is shared between both components.
Comment 2 Florian Müllner 2016-07-07 23:32:36 UTC 
Created attachment 331040 [details] [review]
calendar: Refresh calendar when ignored events changes

The last patch fixed marking days in the calendar where all
events are ignored, but it doesn't pick up the change when
an event is hidden. Emit an appropriate change notification
to fix this issue.
Comment 3 Rui Matos 2016-07-08 12:46:22 UTC 
Review of attachment 331039 [details] [review]:

lgtm
Comment 4 Rui Matos 2016-07-08 12:46:29 UTC 
Review of attachment 331040 [details] [review]:

++
Comment 5 Florian Müllner 2016-07-08 13:03:23 UTC 
Attachment 331039 [details] pushed as 82e6935 - calendar: Move handling of ignored events to event source
Attachment 331040 [details] pushed as 3d77dd8 - calendar: Refresh calendar when ignored events changes