GNOME Bugzilla – Bug 768534
editor-frame: Prevent search position label flickering during replace
Last modified: 2016-07-08 20:43:20 UTC
This fixes one of the flickering bugs slaf pointed out. The other is that the replaced text itself flickers when it's replaced if the replace text contains the search text in it. I haven't been able to figure that one out.
Created attachment 331031 [details] [review] editor-frame: Prevent search position label flickering during replace In ide_editor_frame_actions_replace, when the replace is executed the deletion and insertion in the buffer cause the search position label (e.g. "1 of 29") to be updated, but at that time the occurrences-count is unknown since that part of the buffer needs to be re-scanned, so the label is set to NULL. Only once the scan finishes can the corect label be set. So this commit prevents the search position label from being updated when the cursor moves during the replacement, which prevents ugly flickering for the user.
Review of attachment 331031 [details] [review]: LGTM
Pushed as commit 39a74ba23fa5f0003d474fd30aa8211b957fbd87