After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768532 - h265parse: do not forget VPS/SPS/PPS after pushing codec header
h265parse: do not forget VPS/SPS/PPS after pushing codec header
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-07 20:45 UTC by Thijs Vermeir
Modified: 2018-11-03 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-h265parse-do-not-forget-VPS-SPS-PPS-after-pushing-co.patch (2.84 KB, patch)
2016-07-07 20:45 UTC, Thijs Vermeir 		none Details | Review

Description Thijs Vermeir 2016-07-07 20:45:58 UTC 
Created attachment 331030 [details] [review]
0001-h265parse-do-not-forget-VPS-SPS-PPS-after-pushing-co.patch

have_vps, have_sps and have_pps are used to store if
VPS/SPS/PPS headers are found. This flags should not be cleared
if the codec header is pushed, only when the stream is reset.

In h264parse, this variables are used to store if *new* codec headers
are found and a flag is used to indicate the presence of the codec
headers.

This fixes streaming with config-interval>0.
Comment 1 Jonas Holmberg 2016-07-08 08:58:00 UTC 
The use of have_vps, have_sps and have_pps seems a bit strange even before this change. h265parse->have_vps is written but never read, for example. And h265parse->push_codec seems to be set to FALSE if VPS and PPS have been processed in gst_h265_parse_process_nal() (it doesn't seem to care about SPS in that case).
Comment 2 GStreamer system administrator 2018-11-03 13:53:13 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/408.