After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768525 - subparse: don't reset allowed tags
subparse: don't reset allowed tags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-07 15:47 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-07-07 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
subparse: don't reset allowed tags (1.46 KB, patch)
2016-07-07 15:47 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-07-07 15:47:14 UTC 
See commit log.
Comment 1 Víctor Manuel Jáquez Leal 2016-07-07 15:47:19 UTC 
Created attachment 331004 [details] [review]
subparse: don't reset allowed tags

When a discont buffer is processed, the state is re-initialized, which
nullifies the allowed_tags.

The problem is when a subrip string with tags is processed and allowed_tags is
NULL. The function subrip_unescape_formatting() calls g_strjoinv with a
str_array as NULL, leading to a GLib-CRITICAL.

This patch removes the allowed_tags resetting, in parser_state_init(), but
move it into gst_sub_parse_format_autodetect().
Comment 2 Víctor Manuel Jáquez Leal 2016-07-07 17:39:15 UTC 
Attachment 331004 [details] pushed as c646c62 - subparse: don't reset allowed tags