After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768516 - photos-query: Add query for items in a collection
photos-query: Add query for items in a collection
Status: RESOLVED OBSOLETE
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks: 760839
 
 
Reported: 2016-07-07 13:06 UTC by Rafael Fonseca
Modified: 2018-01-23 10:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add job to query items in a collection (15.57 KB, patch)
2016-07-09 00:33 UTC, Rafael Fonseca
none Details | Review

Description Rafael Fonseca 2016-07-07 13:06:29 UTC
It'd be nice to have a function to get all the items from a collection. Such function can be used for calculating the save size and for exporting items from a collection.

A tentative name could be 'photos_query_collection_items_job_run' which should get as parameter the name of the collection. The _finish function would then return the GList of PhotosBaseItem with the items in the collection.

The challenge of adding such a function is dealing with the use of the current state context in the QueryBuilder code. The easiest solution is to create a new SearchContext inside photos_query_collection_items_job. The "proper" solution is to take the dependency of search context out of the QueryBuilder.
Comment 1 Rafael Fonseca 2016-07-09 00:33:17 UTC
Created attachment 331115 [details] [review]
Add job to query items in a collection

Not quite happy with how this turned out, but it's time to gather some feedback on the overall approach.
Comment 2 GNOME Infrastructure Team 2018-01-23 10:04:55 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-photos/issues/48.