After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768507 - [PATCH] simplify qguark functions
[PATCH] simplify qguark functions
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.48.x
Other Linux
: Normal enhancement
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-07-07 08:38 UTC by ncopa
Modified: 2018-02-16 12:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-gquark-simplify-g_quark_from_static_string-g_quark_f.patch (1.74 KB, patch)
2016-07-07 08:38 UTC, ncopa 		committed Details | Review
0002-gquark-simplify-g_intern_string-g_intern_static_stri.patch (1.87 KB, patch)
2016-07-07 08:39 UTC, ncopa 		committed Details | Review

Description ncopa 2016-07-07 08:38:50 UTC 
Created attachment 330986 [details] [review]
0001-gquark-simplify-g_quark_from_static_string-g_quark_f.patch

There are some repetitive code in gquark. Those two patches move the common code to an inline wrapper function. The compiled code should be the same but we avoid duplicate code in source.
Comment 1 ncopa 2016-07-07 08:39:51 UTC 
Created attachment 330987 [details] [review]
0002-gquark-simplify-g_intern_string-g_intern_static_stri.patch

Second patch which does the same with g_intern_string and g_intern_static_string.
Comment 2 Philip Withnall 2018-02-16 12:50:24 UTC 
Review of attachment 330987 [details] [review]:

Sure.
Comment 3 Philip Withnall 2018-02-16 12:50:33 UTC 
Review of attachment 330986 [details] [review]:

OK, thanks for the cleanups.
Comment 4 Philip Withnall 2018-02-16 12:53:15 UTC 
Thanks for the patches. Both pushed to master.