After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768481 - :q on a horizontal split should just close one pane
:q on a horizontal split should just close one pane
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-06 11:49 UTC by Alexandre Franke
Modified: 2016-12-21 17:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
:q on horizontal split closes one pane (1.09 KB, patch)
2016-12-19 19:22 UTC, Sourav Goyal
none Details | Review

Description Alexandre Franke 2016-07-06 11:49:14 UTC
Currently it closes the document (both splits).
Comment 1 Sourav Goyal 2016-12-19 19:22:10 UTC
Created attachment 342233 [details] [review]
:q on horizontal split closes one pane

When using a horizontal split, the command ':q' closes both the frames instead of just one.

:q used to fire the ide_layout_stack close action which used to close both the frames.
It is changed to fire the ide_editor_view close action which closes just one frame.
Comment 2 sébastien lafargue 2016-12-19 20:04:33 UTC
Alexandre, can you try and tell me if the new behavior is ok for you ?
Comment 3 Alexandre Franke 2016-12-20 15:20:27 UTC
Yes, the behaviour with this patch is the one I expected. Thanks.
Comment 4 sébastien lafargue 2016-12-20 18:28:28 UTC
from irc:

<afranke> if I :sp right after I :q then nothing happens the first time.