After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768467 - avidemux: do not increase num_streams when parse_stream fail
avidemux: do not increase num_streams when parse_stream fail
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-06 02:13 UTC by Seoungil Kang
Modified: 2018-11-03 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for this issue. (854 bytes, patch)
2016-07-06 02:13 UTC, Seoungil Kang 		none Details | Review
Updated patch - add url of this page below commit message. (905 bytes, patch)
2016-07-06 05:54 UTC, Seoungil Kang 		needs-work Details | Review

Description Seoungil Kang 2016-07-06 02:13:16 UTC 
Created attachment 330929 [details] [review]
patch for this issue.

Failure handling code in the function "gst_avi_demux_parse_stream()"
increases num_streams of avi context. It's causing SIGSEGV because the
stream data structure indexed by num_streams is not updated after
initializing to 0 or NULL.
Comment 1 Seoungil Kang 2016-07-06 05:54:30 UTC 
Created attachment 330930 [details] [review]
Updated patch - add url of this page below commit message.
Comment 2 Sebastian Dröge (slomo) 2016-07-07 07:13:58 UTC 
Review of attachment 330930 [details] [review]:

This does not seem correct. The num_streams counter seems to be also used for knowing the "stream index", i.e. see the index handling in that function.

If a stream is skipped because it fails parsing, we should probably make sure that using it elsewhere is just ignoring it instead of crashing later.
Comment 3 GStreamer system administrator 2018-11-03 15:10:21 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/285.