After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768456 - Error compiling Android project after gstreamer upgrade to 1.8.2
Error compiling Android project after gstreamer upgrade to 1.8.2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
1.8.2
Other other
: Normal blocker
: 1.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-05 17:19 UTC by stic
Modified: 2016-07-06 09:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
compilation log (85.65 KB, text/plain)
2016-07-05 17:19 UTC, stic
Details

Description stic 2016-07-05 17:19:16 UTC
Created attachment 330913 [details]
compilation log

Hi,

I wanted to upgrade my Android project from gstreamer 1.6.1 to gstreamer 1.8.2 SDK.
But changing gstreamer SDK to 1.8.2 gives errors, I cannot understand why it does not compile.
Project is using Android Studio with NDK r10e, and is compiled with MacOSX laptop.
There is no problem compiling again with gstreamer 1.6.1.

I attached compilation log.

Thanks for any help.
Comment 1 Sebastian Dröge (slomo) 2016-07-05 17:22:19 UTC
Did you try escaping the \n a bit more to see if that helps?


The problem is that we need to escape them enough so they become newlines, but not too much so they become literal '\n', or too less so they become literal 'n'
Comment 2 stic 2016-07-05 18:53:08 UTC
Escaping more did not change the problem.

BUT I replaced:
# Generate the plugins' declaration strings
GSTREAMER_PLUGINS_DECLARE    := $(foreach plugin, $(GSTREAMER_PLUGINS), \
			GST_PLUGIN_STATIC_DECLARE($(plugin));\n)
# Generate the plugins' registration strings
GSTREAMER_PLUGINS_REGISTER   := $(foreach plugin, $(GSTREAMER_PLUGINS), \
			GST_PLUGIN_STATIC_REGISTER($(plugin));\n)

with:
# Generate the plugins' declaration strings
GSTREAMER_PLUGINS_DECLARE    := $(foreach plugin, $(GSTREAMER_PLUGINS), \
			GST_PLUGIN_STATIC_DECLARE($(plugin)); \
			)
# Generate the plugins' registration strings
GSTREAMER_PLUGINS_REGISTER   := $(foreach plugin, $(GSTREAMER_PLUGINS), \
			GST_PLUGIN_STATIC_REGISTER($(plugin)); \
			)

And now everything is fine.
Thanks for your help.
Comment 3 Sebastian Dröge (slomo) 2016-07-06 09:30:49 UTC
It works fine here with the \n though, but it's only cosmetic anyway. Let's get rid of them for the time being.

It would be great if you could try how to convince your machine to put newlines there though.
Comment 4 Sebastian Dröge (slomo) 2016-07-06 09:33:02 UTC
commit 0bcf75bc5c5b96c67e15e7207d28d645b8195b0b
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Jul 6 12:32:06 2016 +0300

    android: Remove \n from the source generator
    
    On OSX they apparently end up as literal '\n' in the code instead of newlines.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768456