After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768439 - baseparse: Don't add calculated bitrates until threshold
baseparse: Don't add calculated bitrates until threshold
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.8.2
Other All
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-05 11:15 UTC by Jan Alexander Steffens (heftig)
Modified: 2016-07-05 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] baseparse: Don't add calculated bitrates until threshold (3.25 KB, patch)
2016-07-05 11:15 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2016-07-05 11:15:05 UTC 
Created attachment 330897 [details] [review]
[PATCH] baseparse: Don't add calculated bitrates until threshold

Waiting before posting calculated bitrates seems to be the
intent of the code, so avoid adding them to the tag list
pushed with the first frame.

When the threshold is reached, gst_base_parse_update_bitrates
sets tags_changed, so this posts the calculated ones right
that moment.

This prevents an insane average calculated from just the
first (key) frame from getting posted.
Comment 1 Sebastian Dröge (slomo) 2016-07-05 16:35:12 UTC 
Comment on attachment 330897 [details] [review]
[PATCH] baseparse: Don't add calculated bitrates until threshold

Makes sense
Comment 2 Sebastian Dröge (slomo) 2016-07-05 16:43:54 UTC 
commit d71e03b3beea024babb689b3e3a79a177dd9b55e
Author: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Date:   Tue Jul 5 12:17:18 2016 +0200

    baseparse: Don't add calculated bitrates until threshold
    
    Waiting before posting calculated bitrates seems to be the
    intent of the code, so avoid adding them to the tag list
    pushed with the first frame.
    
    When the threshold is reached, gst_base_parse_update_bitrates
    sets tags_changed, so this posts the calculated ones right
    that moment.
    
    This prevents an insane average calculated from just the
    first (key) frame from getting posted.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768439