GNOME Bugzilla – Bug 768419
Geary uses incorrect From address restoring a reply from a draft
Last modified: 2016-07-18 12:16:13 UTC
Hello. It'm using Geary 0.11.1 from Ubuntu PPA and GMail as a mail service. Geary puts an incorrect From field when replying to all. For example, look at this mail: https://lists.zx2c4.com/pipermail/wireguard/2016-July/000098.html . It should be from Artyom (like the first message in a thread), not from Jason. It's not a Mailman bug as the mail in the Sent folder has incorrect From address too. Steps to reproduce: 1. Open a mail from the Inbox folder and press "Reply to all" 2. Write a message, use detached view for email composer 3. Save the message as a draft (don't know if this step is necessary) 4. Open the draft, modify it 5. Press Send.
Hi Artyom, thanks for taking the time to report this. If you still have the message that you were replying to, please attach the email's source as an attachment (do a View Source from the message menu in Geary) so I can see what the headers look like? Does this happen for all messages, just those from mailing lists, or just those from lists addressed to the list and multiple people?
I've tested different scenarios. It doesn't matter if I reply to the list or to the person, also this bug happens if I reply to the single person. The only requirement for the bug reproduction is that I need to save a draft and open it again. I've attached two mails - the original mail to the mail list and a mail to a single person. Both have an invalid address.
Created attachment 330885 [details] Mail to the mail list
Created attachment 330886 [details] Mail to a single person
Another details. 1) I've looked into the draft mail source and the From address in it is correct 2) If I add a second mail account, everything starts to work correctly. If I remove the second account after that, the bug starts to reproduce again.
Thanks for the extra info. So it's getting the From email address right (the part in angle brackets), but the name displayed as part of it is wrong. So somehow these are getting munged together. It's interesting that it only happens when there is a single account - that might be a good clue.
No, both address and name are wrong. Look at the X-Google-Original-From header, that's the original header that came from Geary. GMail silently fixes incorrect addresses, and other mail services may reject such emails or even add a sender to spam list. That's why I think the issue is major.
Created attachment 330932 [details] [review] Don't munge from header when restoring composer from a draft. Possible fix for the the issue. This should apply cleanly to both master and the geary-0.11 branch. Please try rebuilding from source with this patch applied and let me know if it fixes the issue. Thanks!
Works fine now. Thank you!
Great! I just pushed this to master as 6a15b0c, will cherry pick onto geary-0.11 after it gets a bit more testing.
Pushed to geary-0.11 as 3b6bf426.