GNOME Bugzilla – Bug 768392
Remove mapquest map source
Last modified: 2016-07-16 17:12:37 UTC
Due to change in their ToS, we can no longer use it. http://devblog.mapquest.com/2016/06/15/modernization-of-mapquest-results-in-changes-to-open-tile-access/
Created attachment 330861 [details] [review] factory: remove Mapquest map source Due to change in their ToS, we can no longer access their tile servers directly.
Pity. Thanks for letting me know and for the patch.
On second thoughts, gnome-maps and gnome-contact use libchamplain and both of them will break with this change. So instead of removing the string OSM_MAPQUEST we could mark it as deprecated and if someone is using it, we instead use mapnik map source instead of mapquest. And remove it in next release.
Please revert this and do a proper deprecation handling. As noted this breaks the compilation of the mentioned projects and is a serious API break.
Created attachment 331074 [details] [review] factory: remove Mapquest map sources Due to change in their ToS, we can no longer access their tile servers directly.
Sorry for the delay guys. I completely forgot about this but we handled this stuff in the past already with other sources. I reverted the patch and did it the same way as in the past - moved the macros between GTK_DISABLE_DEPRECATED guards and disabled the affected map source registrations into the factory. I also made all the factory functions work the same way - i.e. return NULL when the given map source doesn't exist. I'm afraid all applications using libchamplain and hard-requesting the Mapquest sources will have to be updated anyway - at the moment both of the Mapquest sources return error tiles and these map sources are unusable... Feel free to reopen this bug if you think it should be handled in a different way.
Hi Jiri, You did not mark the CHAMPLAIN_MAP_SOURCE_OSM_AERIAL_MAP as deprecated in the champlain-0.12.vapi in the new patches.
Thanks for noticing, fixed now.