After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768355 - Incorrect initial conditions for nautilus-files-view.c while updating the action state
Incorrect initial conditions for nautilus-files-view.c while updating the act...
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-04 04:16 UTC by tyang
Modified: 2016-09-22 09:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make initial condtions same with the ones in update_selection_menu() (986 bytes, patch)
2016-07-04 04:16 UTC, tyang 		none Details | Review
Patch rebased on top of nautilus 3.21.91 (983 bytes, patch)
2016-08-31 09:20 UTC, Dominique Leuenberger 		reviewed Details | Review
Patch with commit message (1.61 KB, patch)
2016-09-01 10:41 UTC, tyang 		none Details | Review
Modified patch file (1.54 KB, patch)
2016-09-12 05:10 UTC, tyang 		accepted-commit_now Details | Review

Description tyang 2016-07-04 04:16:52 UTC 
Created attachment 330821 [details] [review]
Make initial condtions same with the ones in update_selection_menu()

See it in patch
This could cause the issue when user have icons on desktop and a USB disk was plugged in. It will not show "eject" option on the selection menu.

Thanks
Comment 1 Dominique Leuenberger 2016-08-31 09:20:01 UTC 
Created attachment 334510 [details] [review]
Patch rebased on top of nautilus 3.21.91
Comment 2 Carlos Soriano 2016-09-01 08:12:32 UTC 
Review of attachment 334510 [details] [review]:

Oh yeah it makes sense. Sorry Tyang it took so long to review, it slipped by.

About this patch, it lacks a commit message. Please follow https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines for it.

Thanks for the patch!
Comment 3 tyang 2016-09-01 09:47:20 UTC 
:) OK!

Thanks
Comment 4 tyang 2016-09-01 10:41:05 UTC 
Created attachment 334594 [details] [review]
Patch with commit message

Patch for this issue

Thanks
Comment 5 Carlos Soriano 2016-09-01 11:19:57 UTC 
Review of attachment 334594 [details] [review]:

"In code base, incorrect initial conditions result in no detection for updating the actions status"
This sounds slightly confusing for someone that doesn't read the code before. How about "we were not setting the actions visibility correctly, which makes for example the "Eject" selection menu item not showing up."

"This patch will provide the correct initial conditions in real_update_actions_state()."
not need for functions names, instead how about just "The patch sets the correct initial conditions"
Comment 6 Carlos Soriano 2016-09-01 11:20:23 UTC 
Review of attachment 334594 [details] [review]:

Also please obsolete the patches in the bug report that are no longer valid
Comment 7 tyang 2016-09-02 04:47:08 UTC 
(In reply to Carlos Soriano from comment #5)
> Review of attachment 334594 [details] [review] [review]:
> 
> "In code base, incorrect initial conditions result in no detection for
> updating the actions status"
> This sounds slightly confusing for someone that doesn't read the code
> before. How about "we were not setting the actions visibility correctly,
> which makes for example the "Eject" selection menu item not showing up."
> 
> "This patch will provide the correct initial conditions in
> real_update_actions_state()."
> not need for functions names, instead how about just "The patch sets the
> correct initial conditions"

That's OK

Thanks
Comment 8 tyang 2016-09-12 05:10:13 UTC 
Created attachment 335333 [details] [review]
Modified patch file

Thanks!
Comment 9 Carlos Soriano 2016-09-12 08:21:10 UTC 
Review of attachment 335333 [details] [review]:

Perfect, thanks!