After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768324 - don't show read-only calendars for adding event
don't show read-only calendars for adding event
Status: RESOLVED OBSOLETE
Product: gnome-calendar
Classification: Applications
Component: Edit dialog
unspecified
Other Linux
: Low minor
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-03 07:38 UTC by Mohammed Sadiq
Modified: 2017-11-24 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
edit-dialog: show writable calendars only (1.68 KB, patch)
2016-07-03 07:40 UTC, Mohammed Sadiq 		none Details | Review
quick-add-popover: show writable calendars only (1.01 KB, patch)
2016-07-03 07:41 UTC, Mohammed Sadiq 		none Details | Review
manager: remove unused ::source-activated signal (1.67 KB, patch)
2016-09-28 00:30 UTC, Georges Basile Stavracas Neto 		committed Details | Review
quick-add-popover: only show writable calendars (2.10 KB, patch)
2016-09-28 00:30 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Mohammed Sadiq 2016-07-03 07:38:44 UTC 
Events can't be added to read-only calendars. So it may be better not to show them when adding new events.
Comment 1 Mohammed Sadiq 2016-07-03 07:40:18 UTC 
Created attachment 330804 [details] [review]
edit-dialog: show writable calendars only
Comment 2 Mohammed Sadiq 2016-07-03 07:41:22 UTC 
Created attachment 330805 [details] [review]
quick-add-popover: show writable calendars only
Comment 3 Mohammed Sadiq 2016-09-26 16:07:32 UTC 
Comment on attachment 330805 [details] [review]
quick-add-popover: show writable calendars only

This patch causes issues when the default calendar is read-only.
Comment 4 Mohammed Sadiq 2016-09-26 16:07:36 UTC 
Comment on attachment 330804 [details] [review]
edit-dialog: show writable calendars only

This patch causes issues when the default calendar is read-only.
Comment 5 Georges Basile Stavracas Neto 2016-09-28 00:30:48 UTC 
Created attachment 336396 [details] [review]
manager: remove unused ::source-activated signal

We're not using it anymore, no need to keep it here.
Comment 6 Georges Basile Stavracas Neto 2016-09-28 00:30:54 UTC 
Created attachment 336397 [details] [review]
quick-add-popover: only show writable calendars

There is no reason to display read-only calendars, since the
user can't add any events on it.

Fix that by only showing writable calendars.
Comment 7 Georges Basile Stavracas Neto 2016-09-28 00:31:43 UTC 
Thanks for the reports, and thanks Sadiq for trying it out!

Attachment 336396 [details] pushed as 9da6896 - manager: remove unused ::source-activated signal
Attachment 336397 [details] pushed as a76d40d - quick-add-popover: only show writable calendars
Comment 8 Mohammed Sadiq 2016-10-05 06:50:32 UTC 
This is fixed for the quick-add-popover only. The read-only calendars are still listed in the drop down of Detailed event entry dialog.

Re-opening.
Comment 9 Georges Basile Stavracas Neto 2017-11-24 21:47:28 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-calendar/issues/57.