After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768310 - Audioscrobbler API URLs should be HTTPS
Audioscrobbler API URLs should be HTTPS
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: last.fm
HEAD
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 770774 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-07-02 10:07 UTC by ali
Modified: 2018-05-24 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.83 KB, patch)
2016-07-02 10:07 UTC, ali 		committed Details | Review

Description ali 2016-07-02 10:07:13 UTC 
Created attachment 330770 [details] [review]
patch

Audioscrobbler API URLs are not HTTPS!
I attached a patch[1].

* note[1]: http://turtle.libre.fm/ has a server cert issue!

* comment: please fix the bugzilla component name from `Last.fm` to `audioscrobbler`.
Comment 1 Jonathan Matthew 2016-07-26 22:15:42 UTC 
https://alpha.libre.fm/ has a cert issue too, so I'm not changing that either.
Comment 2 Jonathan Matthew 2016-09-03 01:22:28 UTC 
*** Bug 770774 has been marked as a duplicate of this bug. ***
Comment 3 Jonathan Matthew 2016-09-04 03:53:34 UTC 
commit ce0d391 switches last.fm to https.  leaving this open for libre.fm.
Comment 4 Jonathan Matthew 2016-09-04 03:55:18 UTC 
Review of attachment 330770 [details] [review]:

last.fm bits have been committed
Comment 5 gnome.vrb 2016-09-04 14:22:19 UTC 
https doesn't work for all cases of Last.fm. 

(19:19:01) [0x13b50c0] [rb_audioscrobbler_do_handshake] rb-audioscrobbler.c:887: Performing handshake with Audioscrobbler server: https://post.audioscrobbler.com/?hs=true&p=1.2.1&c=rbx&v=3.4&u=xxxxxxxx&t=1472996941&a=ca00f9059954a346cb9b9224a07ff7ab&api_key=0337ff3c59299b6a31d75164041860b6&sk=37ffb579fa5c3836af1e452b78dfe4e2
...
...
(19:19:01) [0x13b50c0] [rb_audioscrobbler_parse_response] rb-audioscrobbler.c:707: Parsing response, status=200 Reason: OK
(lt-rhythmbox:21730): Rhythmbox-WARNING **: Unexpected last.fm response:
<html><head>
<title>Last.fm API</title>
</head><body>
<p>Please visit <a href="http://www.last.fm/api">http://www.last.fm/api</a></p>
</body></html>

post.audioscrobbler.com works only with http ?
Comment 6 Jonathan Matthew 2016-09-05 10:03:14 UTC 
it appears that way, so I've reverted that part.
Comment 7 ali 2017-10-24 11:16:24 UTC 
Hi,
Libre.FM SSL certs are valid now.
Comment 8 GNOME Infrastructure Team 2018-05-24 18:54:31 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1461.