After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768291 - Add getter for Source:Icon
Add getter for Source:Icon
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.21.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks: 751181
 
 
Reported: 2016-07-01 17:01 UTC by Umang Jain
Modified: 2016-07-01 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
source: Add getter for source icon (1.09 KB, patch)
2016-07-01 17:06 UTC, Umang Jain 		committed Details | Review
source: Add photos_source_get_icon (1.19 KB, patch)
2016-07-01 17:52 UTC, Debarshi Ray 		committed Details | Review

Description Umang Jain 2016-07-01 17:01:07 UTC 
Add a getter function for retrieving the icon (GIcon) associated with a gnome-online-account source.
Comment 1 Umang Jain 2016-07-01 17:06:59 UTC 
Created attachment 330732 [details] [review]
source: Add getter for source icon
Comment 2 Debarshi Ray 2016-07-01 17:51:56 UTC 
Review of attachment 330732 [details] [review]:

Thanks, Umang. Looks good, except that the bug URL is missing.
Comment 3 Debarshi Ray 2016-07-01 17:52:51 UTC 
Created attachment 330741 [details] [review]
source: Add photos_source_get_icon

Added the bug URL and pushed with a slightly better commit message.