After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768243 - Don't create the Cogl GLib source multiple times
Don't create the Cogl GLib source multiple times
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-06-30 12:34 UTC by Owen Taylor
Modified: 2016-06-30 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't create the Cogl GLib source multiple times (1.42 KB, patch)
2016-06-30 12:34 UTC, Owen Taylor
accepted-commit_now Details | Review

Description Owen Taylor 2016-06-30 12:34:12 UTC
Since the check for backend->cogl_context was accidentally moved
to clutter_backend_do_real_create_context, the Glib source that
is created at the end of clutter_backend_do_create_context() is
created and added each time create_context() is called, though
create_context() is supposed to be idempotent.
Comment 1 Owen Taylor 2016-06-30 12:34:15 UTC
Created attachment 330648 [details] [review]
Don't create the Cogl GLib source multiple times
Comment 2 Rui Matos 2016-06-30 12:48:33 UTC
Review of attachment 330648 [details] [review]:

True, please push to mutter too
Comment 3 Owen Taylor 2016-06-30 15:23:03 UTC
Pushed to clutter-1.24, clutter master, and mutter master