After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768219 - Build failure due to missing ServiceData members
Build failure due to missing ServiceData members
Status: RESOLVED FIXED
Product: phodav
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Marc-Andre Lureau
Depends on:
Blocks:
 
 
Reported: 2016-06-30 01:04 UTC by Daniel Stone
Modified: 2016-06-30 10:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build on non-win32 (1.02 KB, patch)
2016-06-30 10:17 UTC, Marc-Andre Lureau 		committed Details | Review

Description Daniel Stone 2016-06-30 01:04:17 UTC 
On Fedora 24, using GNOME 3.22 jhbuild:

/home/daniels/src/gnome/phodav/spice/spice-webdavd.c: In function ‘main’:
/home/daniels/src/gnome/phodav/spice/spice-webdavd.c:1157:15: error: ‘ServiceData {aka struct _ServiceData}’ has no member named ‘drive_letter’
   service_data.drive_letter = 0;
               ^
/home/daniels/src/gnome/phodav/spice/spice-webdavd.c:1158:29: error: ‘ServiceData {aka struct _ServiceData}’ has no member named ‘mutex’
   g_mutex_init(&service_data.mutex);
                             ^
Makefile:1046: recipe for target 'spice/spice_webdavd-spice-webdavd.o' failed


Either the usage should be placed under the G_OS_WIN32 conditional immediately above, or the ServiceData members should be declared unconditionally.
Comment 1 Daniel Stone 2016-06-30 01:07:24 UTC 
This appears to have been introduced with 606ebd7ee3, and I don't believe phodav would have been able to build since on non-Windows OSes.
Comment 2 Marc-Andre Lureau 2016-06-30 10:17:52 UTC 
The following fix has been pushed:
bbcb90a Fix build on non-win32
Comment 3 Marc-Andre Lureau 2016-06-30 10:17:56 UTC 
Created attachment 330643 [details] [review]
Fix build on non-win32

Fixes:
https://bugzilla.gnome.org/show_bug.cgi?id=768219

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>