After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768140 - rtspsrc: Occasional crash on start/stop cycles
rtspsrc: Occasional crash on start/stop cycles
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.8.2
Other Windows
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-28 13:56 UTC by Jonathan Roy
Modified: 2018-11-03 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst_rtspsrc_cleanup patch against concurrent access to streams (1.24 KB, patch)
2016-06-28 13:56 UTC, Jonathan Roy 		needs-work Details | Review

Description Jonathan Roy 2016-06-28 13:56:52 UTC 
Created attachment 330484 [details] [review]
gst_rtspsrc_cleanup patch against concurrent access to streams

Cyclically starting and stopping RTSP stream using rtspsrc may result in crash due to concurrency issue in cleanup method. Attached patch fixes the issue.
Comment 1 Sebastian Dröge (slomo) 2016-06-28 14:13:12 UTC 
Review of attachment 330484 [details] [review]:

While this looks correct (you could use g_list_free_full() btw), it does not look complete. All other places where the streams list is accessed would need to be protected by the same mutex. It looks like currently they are not (and in many places by no mutex at all?!).
Comment 2 GStreamer system administrator 2018-11-03 15:10:10 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/283.