After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768135 - toolbar: add tooltips to view menu buttons
toolbar: add tooltips to view menu buttons
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Low enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-28 12:03 UTC by Ernestas Kulik
Modified: 2016-06-29 08:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
toolbar: add tooltips to view menu buttons (3.48 KB, patch)
2016-06-28 12:04 UTC, Ernestas Kulik 		none Details | Review
toolbar: add tooltips to view menu buttons (6.27 KB, patch)
2016-06-28 17:26 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2016-06-28 12:03:55 UTC 
Attaching a patch for this as discussed over IRC.
This does not remove the AtkObject children and their properties, as they are still important to the a11y tools (e.g. Orca - it reads those).
Comment 1 Ernestas Kulik 2016-06-28 12:04:01 UTC 
Created attachment 330482 [details] [review]
toolbar: add tooltips to view menu buttons

Some button icons don't convey the intended meaning very well (e.g. the
new tab button). This commit adds tooltips to all the buttons in the
view menu.
Comment 2 Razvan Chitu 2016-06-28 12:09:19 UTC 
Awesome! One thing though - I still have an issue with the "New tab" button, as I did not know beforehand the location of the new tab. I'd say it's a good thing to mention that in the tooltip, maybe something like "New tab with current location". Worth checking with Carlos too.
Comment 3 Carlos Soriano 2016-06-28 12:11:43 UTC 
Review of attachment 330482 [details] [review]:

As said on IRC the AtkObject are not necesary anymore. The tooltip creates it underneath.
Comment 4 Ernestas Kulik 2016-06-28 17:26:51 UTC 
Created attachment 330499 [details] [review]
toolbar: add tooltips to view menu buttons

Some button icons don't convey the intended meaning very well (e.g. the
new tab button). This commit adds tooltips to all the buttons in the
view menu.
Comment 5 Ernestas Kulik 2016-06-28 17:28:07 UTC 
So, funny thing. I’ve assigned the tooltip to the icon of the new-tab button and that was the cause of the scare.
Nothing wrong with GTK+, nothing wrong with ATK. Well, in this context. :)
Comment 6 Carlos Soriano 2016-06-29 07:48:16 UTC 
Review of attachment 330499 [details] [review]:

Looks good! Thanks!
Comment 7 Ernestas Kulik 2016-06-29 08:10:36 UTC 
Attachment 330499 [details] pushed as faae4fe - toolbar: add tooltips to view menu buttons