After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768113 - Always crashes on start
Always crashes on start
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Capplet
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks: WaylandRelated
 
 
Reported: 2016-06-27 20:30 UTC by Milan Bouchet-Valat
Modified: 2016-09-15 10:16 UTC
See Also:
GNOME target: 3.22
GNOME version: ---


Description Milan Bouchet-Valat 2016-06-27 20:30:42 UTC 
Several users have reported systematic crashes on Fedora 24, with libgnomekbd version 3.6.0-9. This means the program is totally unusable.

See https://bugzilla.redhat.com/show_bug.cgi?id=1304569.

+ Trace 236397

Thread 1 (Thread 0x7f2e2d8eca00 (LWP 11993))

  • #0 xkl_engine_constructor
    at xklavier.c line 669
  • #1 g_object_new_with_custom_constructor
    at gobject.c line 1699
  • #2 g_object_new_internal
    at gobject.c line 1779
  • #3 g_object_new_valist
    at gobject.c line 2040
  • #4 g_object_new
    at gobject.c line 1624
  • #5 xkl_engine_get_instance
    at xklavier.c line 231
  • #6 main
    at gkbd-keyboard-display.c line 73 






Comment 1


Frederic Crozat





          2016-07-28 12:18:58 UTC
        



crashes when running under Wayland, similar on openSUSE Tumbleweed






Comment 2


Frederic Crozat





          2016-07-28 12:32:40 UTC
        



offending code in gkbd-keyboard-display.c:

display = GDK_DISPLAY_XDISPLAY (gdk_display_get_default ());
engine = xkl_engine_get_instance (display);

it looks like libxklavier needs a way to handle Wayland displays in addition to X11 ones.






Comment 3


Rui Matos





          2016-09-13 16:54:08 UTC
        



I pushed a few cleanups and a fix for the crash to https://git.gnome.org/browse/libgnomekbd/log/?h=wip/rtcm/cleanups

If no one objects I'll push them to master soon.






Comment 4


Michael Catanzaro





          2016-09-13 17:42:53 UTC
        



Note there's a whitespace error it that last commit






Comment 5


Michael Catanzaro





          2016-09-13 17:43:34 UTC
        



Actually in several of the commits; the existing code uses tabs






Comment 6


Rui Matos





          2016-09-15 10:16:51 UTC
        



(In reply to Michael Catanzaro from comment #5)
> Actually in several of the commits; the existing code uses tabs

I fixed this before pushing, thanks for the heads up.

The crash should be fixed now, let me know if that's not the case for you.