After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768106 - preferences: move vcs preferences to preferences-builtin
preferences: move vcs preferences to preferences-builtin
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: preferences
3.20.x
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-27 17:00 UTC by Akshaya Kakkilaya
Modified: 2016-06-28 05:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (14.85 KB, patch)
2016-06-27 17:00 UTC, Akshaya Kakkilaya 		none Details | Review
patch(updated) (14.87 KB, patch)
2016-06-28 04:47 UTC, Akshaya Kakkilaya 		committed Details | Review

Description Akshaya Kakkilaya 2016-06-27 17:00:53 UTC 
Created attachment 330454 [details] [review]
patch

vcs settings can now use vcs-config from preferences-builtin instead of preference addins.
Comment 1 Christian Hergert 2016-06-27 20:53:29 UTC 
Review of attachment 330454 [details] [review]:

Looks good, just a couple style nits.

::: libide/preferences/ide-preferences-builtin.c
@@ -323,0 +324,52 @@
+static void
+author_changed_cb (IdePreferencesEntry *entry,
+                   const gchar         *text,
... 49 more ...

Always initialize autofree variables to NULL.

@@ -323,0 +324,80 @@
+static void
+author_changed_cb (IdePreferencesEntry *entry,
+                   const gchar         *text,
... 77 more ...

space before open parens.
Comment 2 Akshaya Kakkilaya 2016-06-28 04:47:50 UTC 
Created attachment 330470 [details] [review]
patch(updated)
Comment 3 Christian Hergert 2016-06-28 05:08:29 UTC 
Thanks!