Bug 767993 – empathy-chat using deprecated css properties

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 767993 - empathy-chat using deprecated css properties


Summary:	empathy-chat using deprecated css properties


Status:	RESOLVED OBSOLETE

Product:	empathy
Classification:	Core
Component:	Chat
Version:	3.12.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	empathy-maint
QA Contact:	empathy-maint

URL:
Whiteboard:

Duplicates:	765866 (view as bug list)
Depends on:
Blocks:

Reported:	2016-06-24 05:57 UTC by Diane Trout
Modified:	2018-05-22 19:10 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
One attempt to port the CSS (435 bytes, text/plain) 2016-06-24 06:31 UTC, Diane Trout	Details
This also appears to work. (377 bytes, text/plain) 2016-06-24 06:37 UTC, Diane Trout	Details

Description Diane Trout 2016-06-24 05:57:23 UTC

empathy-chat is using some deprecated CSS values:

Running /usr/lib/empathy/empathy-chat gives the following warnings:

(empathy:4520): Gtk-WARNING **: Theme parsing error: empathy.css:2:30: The style property GtkButton:default-border is deprecated and shouldn't be used anymore. It will be removed in a future version

(empathy:4520): Gtk-WARNING **: Theme parsing error: empathy.css:3:38: The style property GtkButton:default-outside-border is deprecated and shouldn't be used anymore. It will be removed in a future version

(empathy:4520): Gtk-WARNING **: Theme parsing error: empathy.css:4:27: The style property GtkButton:inner-border is deprecated and shouldn't be used anymore. It will be removed in a future version

(empathy:4520): Gtk-WARNING **: Theme parsing error: empathy.css:5:32: The style property GtkWidget:focus-line-width is deprecated and shouldn't be used anymore. It will be removed in a future version

(empathy:4520): Gtk-WARNING **: Theme parsing error: empathy.css:6:29: The style property GtkWidget:focus-padding is deprecated and shouldn't be used anymore. It will be removed in a future version
** Message: console message: undefined @0: TypeError: undefined is not a function

Comment 1 Diane Trout 2016-06-24 06:31:39 UTC

Created attachment 330291 [details]
One attempt to port the CSS

Comment 2 Diane Trout 2016-06-24 06:37:24 UTC

Created attachment 330292 [details]
This also appears to work.

The only thing that seemed to change the size of the tab bar was the padding: attribute. So this also seems to work.

Comment 3 Debarshi Ray 2016-06-27 14:19:06 UTC

*** Bug 765866 has been marked as a duplicate of this bug. ***

Comment 4 Hussam Al-Tayeb 2016-07-05 17:37:48 UTC

(In reply to Diane Trout from comment #2)
> Created attachment 330292 [details]
> This also appears to work.
> 
> The only thing that seemed to change the size of the tab bar was the
> padding: attribute. So this also seems to work.

This fixes the css warning for me from bug 765866.
Only remaining issue is:
Jul 05 19:12:43 hades org.freedesktop.Telepathy.Client.Empathy.Chat[5488]: (empathy:6222): Gtk-WARNING **: Allocating size to EmpathyChatWindow 0xc227b0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?

Comment 5 GNOME Infrastructure Team 2018-05-22 19:10:35 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/873.