After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767992 - soup_session_async_new is deprecated
soup_session_async_new is deprecated
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
3.12.x
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2016-06-24 05:48 UTC by Diane Trout
Modified: 2016-06-27 16:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch replacing deprecated call (979 bytes, patch)
2016-06-24 05:48 UTC, Diane Trout
none Details | Review
debug-window: Replace deprecated soup_session_async_new (1.49 KB, patch)
2016-06-27 12:52 UTC, Debarshi Ray
committed Details | Review

Description Diane Trout 2016-06-24 05:48:04 UTC
Created attachment 330289 [details] [review]
patch replacing deprecated call

soup_session_async_new is deprecated, I changed it to soup_session_new and checked the porting guide https://developer.gnome.org/libsoup/stable/libsoup-session-porting.html

I didn't see any use of async-context or use-thread-context, nor did I see any calls to soup_session_cancel_message.

There's just soup_session_new and a call to soup_sessin_queue_message. And this is just in src/empathy-debug-window.c
Comment 1 Debarshi Ray 2016-06-27 12:51:26 UTC
Review of attachment 330289 [details] [review]:

Thanks for the patch, Diane. It looks good, but we should bump the libsoup requirement to 2.42.0 in configure.ac and add the URL of this bug in the commit message.
Comment 2 Debarshi Ray 2016-06-27 12:52:16 UTC
Created attachment 330434 [details] [review]
debug-window: Replace deprecated soup_session_async_new

I took the liberty to fix it up.
Comment 3 Debarshi Ray 2016-06-27 12:55:32 UTC
Comment on attachment 330434 [details] [review]
debug-window: Replace deprecated soup_session_async_new

Pushed to master.
Comment 4 Diane Trout 2016-06-27 16:40:45 UTC
(In reply to Debarshi Ray from comment #1)
> Review of attachment 330289 [details] [review] [review]:
> 
> Thanks for the patch, Diane. It looks good, but we should bump the libsoup
> requirement to 2.42.0 in configure.ac and add the URL of this bug in the
> commit message.

Ooops right. I forgot to update that, thank you.