GNOME Bugzilla – Bug 767992
soup_session_async_new is deprecated
Last modified: 2016-06-27 16:40:45 UTC
Created attachment 330289 [details] [review] patch replacing deprecated call soup_session_async_new is deprecated, I changed it to soup_session_new and checked the porting guide https://developer.gnome.org/libsoup/stable/libsoup-session-porting.html I didn't see any use of async-context or use-thread-context, nor did I see any calls to soup_session_cancel_message. There's just soup_session_new and a call to soup_sessin_queue_message. And this is just in src/empathy-debug-window.c
Review of attachment 330289 [details] [review]: Thanks for the patch, Diane. It looks good, but we should bump the libsoup requirement to 2.42.0 in configure.ac and add the URL of this bug in the commit message.
Created attachment 330434 [details] [review] debug-window: Replace deprecated soup_session_async_new I took the liberty to fix it up.
Comment on attachment 330434 [details] [review] debug-window: Replace deprecated soup_session_async_new Pushed to master.
(In reply to Debarshi Ray from comment #1) > Review of attachment 330289 [details] [review] [review]: > > Thanks for the patch, Diane. It looks good, but we should bump the libsoup > requirement to 2.42.0 in configure.ac and add the URL of this bug in the > commit message. Ooops right. I forgot to update that, thank you.