After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767987 - Crash in nmc_find_connection() when connecting to a password protected wlan connection
Crash in nmc_find_connection() when connecting to a password protected wlan c...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nmcli
1.2.x
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-23 21:18 UTC by Aron Xu
Modified: 2016-06-27 11:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] cli: initialize connection list in do_device_connect() (1.31 KB, patch)
2016-06-24 12:18 UTC, Beniamino Galvani 		none Details | Review

Description Aron Xu 2016-06-23 21:18:19 UTC 
Ubuntu error tracker receives some reports agains 1.2.0 for a crash in nmc_find_connection() when connecting to a password protected wlan connection, by running command: nmcli device connect wlan0

Stacktrace

+ Trace 236385

  • #0 nmc_find_connection
    at common.c line 893
  • #1 nmc_secrets_requested
    at common.c line 1095
  • #2 ffi_call_unix64
    at ../src/x86/unix64.S line 76
  • #3 ffi_call
    at ../src/x86/ffi64.c line 525
  • #4 g_cclosure_marshal_generic_va
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gobject/gclosure.c line 1604
  • #5 _g_closure_invoke_va
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gobject/gclosure.c line 867
  • #6 g_signal_emit_valist
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gobject/gsignal.c line 3294
  • #7 g_signal_emit
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gobject/gsignal.c line 3441
  • #8 request_secrets_from_ui
    at ./../common/nm-secret-agent-simple.c line 552
  • #9 nm_secret_agent_simple_enable
    at ./../common/nm-secret-agent-simple.c line 759
  • #10 connect_device_cb
    at devices.c line 1643
  • #11 g_simple_async_result_complete
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gio/gsimpleasyncresult.c line 801
  • #12 activate_cb
    at nm-client.c line 871
  • #13 g_simple_async_result_complete
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gio/gsimpleasyncresult.c line 801
  • #14 activate_info_complete
    at nm-manager.c line 778
  • #15 g_cclosure_marshal_VOID__OBJECTv
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gobject/gmarshal.c line 2102
  • #16 _g_closure_invoke_va
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gobject/gclosure.c line 867
  • #17 g_signal_emit_valist
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gobject/gsignal.c line 3294
  • #18 g_signal_emit_by_name
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./gobject/gsignal.c line 3481
  • #19 deferred_notify_cb
    at nm-object.c line 243
  • #20 g_main_dispatch
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./glib/gmain.c line 3154
  • #21 g_main_context_dispatch
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./glib/gmain.c line 3769
  • #22 g_main_context_iterate
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./glib/gmain.c line 3840
  • #23 g_main_loop_run
    at /build/glib2.0-t9oPgV/glib2.0-2.48.0/./glib/gmain.c line 4034
  • #24 main
    at nmcli.c line 631 






Comment 1


Beniamino Galvani





          2016-06-24 12:18:40 UTC
        



Created attachment 330311 [details] [review]
[PATCH] cli: initialize connection list in do_device_connect()






Comment 2


Thomas Haller





          2016-06-24 12:48:18 UTC
        



This may fix the bug, so ACK to that.

But eventually, we really should get rid of this NmCli instance...






Comment 3


Francesco Giudici





          2016-06-27 10:38:27 UTC
        



lgtm