After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767974 - rpmspec: add support for %global and Enhances
rpmspec: add support for %global and Enhances
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
unspecified
Other All
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
: 767973 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-06-23 11:34 UTC by Igor Gnatenko
Modified: 2016-06-23 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rpmspec: add support for %global macro (1.15 KB, patch)
2016-06-23 11:34 UTC, Igor Gnatenko
accepted-commit_now Details | Review
rpmspec: add support for Enhances tag (856 bytes, patch)
2016-06-23 11:34 UTC, Igor Gnatenko
accepted-commit_now Details | Review

Description Igor Gnatenko 2016-06-23 11:34:46 UTC
those were added long time ago.
Comment 1 Igor Gnatenko 2016-06-23 11:34:50 UTC
Created attachment 330248 [details] [review]
rpmspec: add support for %global macro

Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 2 Igor Gnatenko 2016-06-23 11:34:55 UTC
Created attachment 330249 [details] [review]
rpmspec: add support for Enhances tag

Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 3 Sébastien Wilmet 2016-06-23 12:06:54 UTC
*** Bug 767973 has been marked as a duplicate of this bug. ***
Comment 4 Sébastien Wilmet 2016-06-23 12:11:24 UTC
Review of attachment 330248 [details] [review]:

Looks good.
Comment 5 Sébastien Wilmet 2016-06-23 12:12:07 UTC
Review of attachment 330249 [details] [review]:

Looks good.
Comment 6 Igor Gnatenko 2016-06-23 12:25:33 UTC
Pushed.

* ddd02ed rpmspec: add support for Enhances tag
* 40fb4ab rpmspec: add support for %global macro