After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767963 - Add G_FILE_ATTRIBUTE_FILESYSTEM_REMOTE attribute
Add G_FILE_ATTRIBUTE_FILESYSTEM_REMOTE attribute
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 767964 767965
 
 
Reported: 2016-06-23 06:25 UTC by Ondrej Holy
Modified: 2016-06-28 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fileinfo: Add G_FILE_ATTRIBUTE_FILESYSTEM_REMOTE attribute (2.95 KB, patch)
2016-06-23 06:25 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2016-06-23 06:25:27 UTC 
Created attachment 330233 [details] [review]
fileinfo: Add G_FILE_ATTRIBUTE_FILESYSTEM_REMOTE attribute

GTK+ contains helper function _gtk_file_consider_as_remote for remote locations, which is based on hardcoded list of filesystem types:
https://git.gnome.org/browse/gtk+/tree/gtk/gtkfilesystem.c#n905

It would be really nice to provide this information directly from GIO layer and do not use hardcoded lists as suggested by Matthias:
https://bugzilla.gnome.org/show_bug.cgi?id=754746#c3

Let's add/set/use G_FILE_ATTRIBUTE_FILESYSTEM_REMOTE for this need.

I tested the patches successfully using gtk+/tests/testfilechooser.
Comment 1 Matthias Clasen 2016-06-24 20:35:55 UTC 
Review of attachment 330233 [details] [review]:

looks ok to me
Comment 2 Ondrej Holy 2016-06-28 08:42:39 UTC 
Comment on attachment 330233 [details] [review]
fileinfo: Add G_FILE_ATTRIBUTE_FILESYSTEM_REMOTE attribute

Thanks for the review, pushed as commit e57355b.